ink to configured gravatar host on profile page
This commit is contained in:
parent
88a3cfe107
commit
0f785bbc7e
5 changed files with 19 additions and 2 deletions
|
@ -28,6 +28,7 @@ v 7.14.0 (unreleased)
|
|||
- Show buttons to add license, changelog and contribution guide if they're missing.
|
||||
- Disabled autocapitalize and autocorrect on login field (Daryl Chan)
|
||||
- Mention group and project name in creation, update and deletion notices (Achilleas Pipinellis)
|
||||
- Update gravatar link on profile page to link to configured gravatar host (Ben Bodenmiller)
|
||||
- Remove redis-store TTL monkey patch
|
||||
|
||||
v 7.13.2
|
||||
|
|
|
@ -82,12 +82,12 @@
|
|||
You can change your avatar here
|
||||
- if Gitlab.config.gravatar.enabled
|
||||
%br
|
||||
or remove the current avatar to revert to #{link_to "gravatar.com", "http://gravatar.com"}
|
||||
or remove the current avatar to revert to #{link_to Gitlab.config.gravatar.host, "http://" + Gitlab.config.gravatar.host}
|
||||
- else
|
||||
You can upload an avatar here
|
||||
- if Gitlab.config.gravatar.enabled
|
||||
%br
|
||||
or change it at #{link_to "gravatar.com", "http://gravatar.com"}
|
||||
or change it at #{link_to Gitlab.config.gravatar.host, "http://" + Gitlab.config.gravatar.host}
|
||||
%hr
|
||||
%a.choose-btn.btn.btn-sm.js-choose-user-avatar-button
|
||||
%i.fa.fa-paperclip
|
||||
|
|
|
@ -8,6 +8,15 @@ class Settings < Settingslogic
|
|||
def gitlab_on_standard_port?
|
||||
gitlab.port.to_i == (gitlab.https ? 443 : 80)
|
||||
end
|
||||
|
||||
# get host without www, thanks to http://stackoverflow.com/a/6674363/1233435
|
||||
def get_host_without_www(url)
|
||||
url = URI.encode(url)
|
||||
uri = URI.parse(url)
|
||||
uri = URI.parse("http://#{url}") if uri.scheme.nil?
|
||||
host = uri.host.downcase
|
||||
host.start_with?('www.') ? host[4..-1] : host
|
||||
end
|
||||
|
||||
private
|
||||
|
||||
|
@ -147,6 +156,7 @@ Settings['gravatar'] ||= Settingslogic.new({})
|
|||
Settings.gravatar['enabled'] = true if Settings.gravatar['enabled'].nil?
|
||||
Settings.gravatar['plain_url'] ||= 'http://www.gravatar.com/avatar/%{hash}?s=%{size}&d=identicon'
|
||||
Settings.gravatar['ssl_url'] ||= 'https://secure.gravatar.com/avatar/%{hash}?s=%{size}&d=identicon'
|
||||
Settings.gravatar['host'] = Settings.get_host_without_www(Settings.gravatar['plain_url'])
|
||||
|
||||
#
|
||||
# GitLab Shell
|
||||
|
|
|
@ -35,6 +35,7 @@ Feature: Profile
|
|||
Then I change my avatar
|
||||
And I should see new avatar
|
||||
And I should see the "Remove avatar" button
|
||||
And I should see the gravatar host link
|
||||
|
||||
Scenario: I remove my avatar
|
||||
Given I visit profile page
|
||||
|
@ -42,6 +43,7 @@ Feature: Profile
|
|||
When I remove my avatar
|
||||
Then I should see my gravatar
|
||||
And I should not see the "Remove avatar" button
|
||||
And I should see the gravatar host link
|
||||
|
||||
Scenario: My password is expired
|
||||
Given my password is expired
|
||||
|
|
|
@ -59,6 +59,10 @@ class Spinach::Features::Profile < Spinach::FeatureSteps
|
|||
step 'I should not see the "Remove avatar" button' do
|
||||
expect(page).not_to have_link("Remove avatar")
|
||||
end
|
||||
|
||||
step 'I should see the gravatar host link' do
|
||||
expect(page).to have_link("gravatar.com")
|
||||
end
|
||||
|
||||
step 'I try change my password w/o old one' do
|
||||
page.within '.update-password' do
|
||||
|
|
Loading…
Reference in a new issue