kotovalexarian-likes-gitlab
/
gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Don't use chmod_R for backup tars 

When creating backup tar files, only change permissions on the `db`,
`uploads`, and `repositories` directories, not their contents.
This commit is contained in:
Vinnie Okada 2015-03-28 08:38:48 -06:00
parent 6664da431a
commit 0f78d92e4c
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/backup/manager.rb
View File

@ -17,7 +17,7 @@ module Backup
file << s.to_yaml.gsub(/^---\n/,'')
end
FileUtils.chmod_R(0700, %w{db uploads repositories})
FileUtils.chmod(0700, %w{db uploads repositories})
# create archive
$progress.print "Creating backup archive: #{tar_file} ... "

2
spec/tasks/gitlab/backup_rake_spec.rb
View File

@ -87,7 +87,7 @@ describe 'gitlab:app namespace rake task' do
expect(tar_contents).to match('db/')
expect(tar_contents).to match('uploads/')
expect(tar_contents).to match('repositories/')
expect(tar_contents).not_to match(/^.{4,9}[rwx]/)
expect(tar_contents).not_to match(/^.{4,9}[rwx].*(db|uploads|repositories)\/$/)
end
it 'should delete temp directories' do