From 0f8c36b8d7e73c78c87422763d4afceeea244689 Mon Sep 17 00:00:00 2001 From: dosire Date: Thu, 9 Jan 2014 09:30:01 +0100 Subject: [PATCH] Ask people to link bakc and be prepared for feedback. --- CONTRIBUTING.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 50cea84e0ff..52061c588a0 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -63,8 +63,9 @@ If you can, please submit a merge request with the fix or improvements including 1. Submit a merge request (MR) 1. The MR title should describes the change you want to make 1. The MR description should give a motive for your change and the method you used to achieve it -* If the MR changes the UI it should include before and after screenshots -1. [Search for issues](https://gitlab.com/gitlab-org/gitlab-ce/issues) related to your merge request and mention them in the merge request description +1. If the MR changes the UI it should include before and after screenshots +1. Link relevant [issues](https://gitlab.com/gitlab-org/gitlab-ce/issues) and/or [feedback items](http://feedback.gitlab.com/) from the merge request description and leave a comment on them with a link back to the MR +1. Be prepared to answer questions and incorporate feedback even if requests for this arrive weeks or months after your MR submittion Please keep the change in a single MR as small as possible. If you want to contribute a large feature think very hard what the minimum viable change is. Can you split functionality? Can you only submit the backend/API code? Can you start with a very simple UI? The smaller a MR is the more likely it is it will be merged, after that you can send more MR's to enhance it.