kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

updated system note service and spec based on feedback

Browse source
This commit is contained in:
James Lopez 2016-02-16 09:01:56 +01:00
parent 99a50447a1
commit 11913a762a
2 changed files with 3 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
app/services/system_note_service.rb
View file

@ -274,7 +274,9 @@ class SystemNoteService
# Check if a cross reference to a noteable from a mentioner already exists # Check if a cross reference to a noteable from a mentioner already exists
# #
# This method is used to prevent multiple notes being created for a mention # This method is used to prevent multiple notes being created for a mention
# when a issue is updated, for example. # when a issue is updated, for example. The method also calls notes_for_mentioner
# to check if the mentioner is a commit, and return matches only on commit hash
# instead of project + commit, to avoid repeated mentions from forks.
# #
# noteable - Noteable object being referenced # noteable - Noteable object being referenced
# mentioner - Mentionable object # mentioner - Mentionable object

4
spec/services/system_note_service_spec.rb
View file

@ -431,10 +431,6 @@ describe SystemNoteService, services: true do
let(:commit2) { forked_project.commit } let(:commit2) { forked_project.commit }
before do before do
allow(commit0).to receive(:to_reference) {
noteable.project.to_reference +
commit0.class.reference_prefix + commit0.id
}
described_class.cross_reference(noteable, commit0, author2) described_class.cross_reference(noteable, commit0, author2)
end end