Update CI Variable presenters paths

This commit is contained in:
Matija Čupić 2018-01-23 21:26:30 +01:00
parent 2592aec9e3
commit 1292c158ce
No known key found for this signature in database
GPG Key ID: 4BAF84FFACD2E5DE
4 changed files with 14 additions and 40 deletions

View File

@ -7,19 +7,15 @@ module Ci
end end
def form_path def form_path
if variable.persisted? group_settings_ci_cd_path(group)
group_variable_path(group, variable)
else
group_variables_path(group)
end
end end
def edit_path def edit_path
group_variable_path(group, variable) group_variables_save_multiple_path(group)
end end
def delete_path def delete_path
group_variable_path(group, variable) group_variables_save_multiple_path(group)
end end
end end
end end

View File

@ -7,19 +7,15 @@ module Ci
end end
def form_path def form_path
if variable.persisted? project_settings_ci_cd_path(project)
project_variable_path(project, variable)
else
project_variables_path(project)
end
end end
def edit_path def edit_path
project_variable_path(project, variable) project_variables_save_multiple_path(project)
end end
def delete_path def delete_path
project_variable_path(project, variable) project_variables_save_multiple_path(project)
end end
end end
end end

View File

@ -35,29 +35,20 @@ describe Ci::GroupVariablePresenter do
end end
describe '#form_path' do describe '#form_path' do
context 'when variable is persisted' do subject { described_class.new(variable).form_path }
subject { described_class.new(variable).form_path }
it { is_expected.to eq(group_variable_path(group, variable)) } it { is_expected.to eq(group_settings_ci_cd_path(group)) }
end
context 'when variable is not persisted' do
let(:variable) { build(:ci_group_variable, group: group) }
subject { described_class.new(variable).form_path }
it { is_expected.to eq(group_variables_path(group)) }
end
end end
describe '#edit_path' do describe '#edit_path' do
subject { described_class.new(variable).edit_path } subject { described_class.new(variable).edit_path }
it { is_expected.to eq(group_variable_path(group, variable)) } it { is_expected.to eq(group_variables_save_multiple_path(group)) }
end end
describe '#delete_path' do describe '#delete_path' do
subject { described_class.new(variable).delete_path } subject { described_class.new(variable).delete_path }
it { is_expected.to eq(group_variable_path(group, variable)) } it { is_expected.to eq(group_variables_save_multiple_path(group)) }
end end
end end

View File

@ -35,29 +35,20 @@ describe Ci::VariablePresenter do
end end
describe '#form_path' do describe '#form_path' do
context 'when variable is persisted' do subject { described_class.new(variable).form_path }
subject { described_class.new(variable).form_path }
it { is_expected.to eq(project_variable_path(project, variable)) } it { is_expected.to eq(project_settings_ci_cd_path(project)) }
end
context 'when variable is not persisted' do
let(:variable) { build(:ci_variable, project: project) }
subject { described_class.new(variable).form_path }
it { is_expected.to eq(project_variables_path(project)) }
end
end end
describe '#edit_path' do describe '#edit_path' do
subject { described_class.new(variable).edit_path } subject { described_class.new(variable).edit_path }
it { is_expected.to eq(project_variable_path(project, variable)) } it { is_expected.to eq(project_variables_save_multiple_path(project)) }
end end
describe '#delete_path' do describe '#delete_path' do
subject { described_class.new(variable).delete_path } subject { described_class.new(variable).delete_path }
it { is_expected.to eq(project_variable_path(project, variable)) } it { is_expected.to eq(project_variables_save_multiple_path(project)) }
end end
end end