Simplify resource_label_events API shared example

We don't need a repository, and we only need a private user in one
example, so we can scope it locally there.
This commit is contained in:
Robert Speicher 2019-07-25 11:10:31 -05:00
parent d5c1081395
commit 148df25638
No known key found for this signature in database
GPG Key ID: 1D812769A7706642
2 changed files with 2 additions and 2 deletions

View File

@ -4,8 +4,7 @@ require 'spec_helper'
describe API::ResourceLabelEvents do
set(:user) { create(:user) }
set(:project) { create(:project, :public, :repository, namespace: user.namespace) }
set(:private_user) { create(:user) }
set(:project) { create(:project, :public, namespace: user.namespace) }
before do
project.add_developer(user)

View File

@ -19,6 +19,7 @@ shared_examples 'resource_label_events API' do |parent_type, eventable_type, id_
it "returns 404 when not authorized" do
parent.update!(visibility_level: Gitlab::VisibilityLevel::PRIVATE)
private_user = create(:user)
get api("/#{parent_type}/#{parent.id}/#{eventable_type}/#{eventable[id_name]}/resource_label_events", private_user)