From 0e7665e09b75a5ddeed16df894f31a632d7338aa Mon Sep 17 00:00:00 2001 From: Marin Jankovski Date: Thu, 3 Apr 2014 13:24:05 +0200 Subject: [PATCH 1/2] Only send email when project access level changes. --- app/observers/users_project_observer.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/observers/users_project_observer.rb b/app/observers/users_project_observer.rb index 93233898cc8..44c72b30187 100644 --- a/app/observers/users_project_observer.rb +++ b/app/observers/users_project_observer.rb @@ -10,7 +10,7 @@ class UsersProjectObserver < BaseObserver end def after_update(users_project) - notification.update_team_member(users_project) + notification.update_team_member(users_project) if users_project.project_access_changed? end def after_destroy(users_project) From eca269f7f98b3a2455e7788c884bcb927ea693b1 Mon Sep 17 00:00:00 2001 From: Marin Jankovski Date: Thu, 3 Apr 2014 16:35:33 +0200 Subject: [PATCH 2/2] Fix user_project observer test. --- spec/observers/users_project_observer_spec.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spec/observers/users_project_observer_spec.rb b/spec/observers/users_project_observer_spec.rb index be277b4dbd2..b024465e8c3 100644 --- a/spec/observers/users_project_observer_spec.rb +++ b/spec/observers/users_project_observer_spec.rb @@ -21,7 +21,7 @@ describe UsersProjectObserver do it "should send email to user" do subject.should_receive(:notification) - @users_project.update_attribute(:project_access, UsersProject::MASTER) + @users_project.update_attribute(:project_access, UsersProject::OWNER) end it "should not called after UsersProject destroyed" do