kotovalexarian-likes-gitlab
/
gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Switch back to the '--wait' flag for the 'helm upgrade' command 

Signed-off-by: Rémy Coutable <remy@rymai.me>
This commit is contained in:
Rémy Coutable 2019-08-27 13:01:13 +02:00
parent 4bf01ce52f
commit 1593583337
No known key found for this signature in database
GPG Key ID: 98DFFD1C0C62B70B
2 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
.gitlab/ci/review.gitlab-ci.yml
View File

@ -128,8 +128,9 @@ review-stop:
- source utils.sh - source utils.sh
- source review-apps.sh - source review-apps.sh
script: script:
- delete - delete_release
artifacts: {} artifacts:
paths: []
.review-qa-base: .review-qa-base:
extends: extends:

5
scripts/review_apps/review-apps.sh
View File

@ -36,7 +36,7 @@ function previous_deploy_failed() {
return $status return $status
} }
function delete() { function delete_release() {
if [ -z "$CI_ENVIRONMENT_SLUG" ]; then if [ -z "$CI_ENVIRONMENT_SLUG" ]; then
echoerr "No release given, aborting the delete!" echoerr "No release given, aborting the delete!"
return return
@ -193,7 +193,8 @@ function deploy() {
HELM_CMD=$(cat << EOF HELM_CMD=$(cat << EOF
helm upgrade --install \ helm upgrade --install \
--atomic \ --force \
--wait \
--timeout 900 \ --timeout 900 \
--set releaseOverride="$CI_ENVIRONMENT_SLUG" \ --set releaseOverride="$CI_ENVIRONMENT_SLUG" \
--set global.appConfig.enableUsagePing=false \ --set global.appConfig.enableUsagePing=false \