From 16daf112d6cfe2c87d8837382a00d88aa8c0ff5c Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Wed, 14 Sep 2022 12:12:34 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .../components/new_access_token_app.vue | 10 +- app/assets/javascripts/api.js | 1 + .../components/state_container.vue | 9 +- .../components/states/mr_widget_closed.vue | 25 +- app/models/ci/pipeline_variable.rb | 5 +- app/models/commit.rb | 16 ++ app/services/merge_requests/update_service.rb | 14 +- app/services/projects/update_pages_service.rb | 11 +- ...ecords_to_ghost_user_in_batches_service.rb | 26 ++ .../migrate_records_to_ghost_user_service.rb | 6 +- ...merge_request_draft_status_email.html.haml | 8 +- ..._merge_request_draft_status_email.text.erb | 6 +- app/workers/all_queues.yml | 36 +++ .../github_import/advance_stage_worker.rb | 1 + .../import_protected_branch_worker.rb | 23 ++ .../stage/import_attachments_worker.rb | 6 +- .../stage/import_protected_branches_worker.rb | 45 ++++ app/workers/issues/close_worker.rb | 50 ++++ app/workers/process_commit_worker.rb | 39 ++- ...records_to_ghost_user_in_batches_worker.rb | 22 ++ ...s_async_project_authorizations_refresh.yml | 2 +- .../process_issue_closure_in_background.yml | 8 + ...roy_with_limited_execution_time_worker.yml | 8 + config/initializers/1_settings.rb | 5 +- .../20220825232557_count_user_auth.yml | 24 ++ .../20220825232556_count_user_auth.yml | 3 +- config/settings.rb | 6 + config/sidekiq_queues.yml | 2 + db/fixtures/development/17_cycle_analytics.rb | 2 + db/fixtures/development/24_forks.rb | 2 + ..._gitlab_instance_administration_project.rb | 5 +- .../documentation/restful_api_styleguide.md | 38 +-- doc/development/github_importer.md | 11 +- doc/user/analytics/ci_cd_analytics.md | 2 +- doc/user/project/import/github.md | 1 + lib/gitlab/audit/type/definition.rb | 122 ++++++++++ lib/gitlab/github_import/client.rb | 8 + .../importer/protected_branch_importer.rb | 48 ++++ .../importer/protected_branches_importer.rb | 52 ++++ .../representation/protected_branch.rb | 46 ++++ .../github_import/sequential_importer.rb | 1 + lib/gitlab/utils/execution_tracker.rb | 25 ++ locale/gitlab.pot | 7 +- spec/config/settings_spec.rb | 14 ++ .../projects/commits/multi_view_diff_spec.rb | 5 +- .../components/new_access_token_app_spec.js | 32 ++- .../states/mr_widget_closed_spec.js | 6 +- spec/lib/gitlab/audit/type/definition_spec.rb | 219 +++++++++++++++++ .../diff/rendered/notebook/diff_file_spec.rb | 3 +- spec/lib/gitlab/git/commit_stats_spec.rb | 16 +- spec/lib/gitlab/git/compare_spec.rb | 5 +- spec/lib/gitlab/git/diff_collection_spec.rb | 2 +- .../gitlab/git/rugged_impl/use_rugged_spec.rb | 2 +- spec/lib/gitlab/github_import/client_spec.rb | 24 ++ .../protected_branch_importer_spec.rb | 91 +++++++ .../protected_branches_importer_spec.rb | 222 ++++++++++++++++++ .../representation/protected_branch_spec.rb | 51 ++++ .../duplicate_jobs/server_spec.rb | 8 +- spec/lib/gitlab/sidekiq_migrate_jobs_spec.rb | 8 +- spec/lib/gitlab/sidekiq_queue_spec.rb | 10 +- .../gitlab/utils/execution_tracker_spec.rb | 24 ++ spec/models/ci/pipeline_variable_spec.rb | 21 ++ spec/models/commit_spec.rb | 16 ++ .../blobs/notebook_presenter_spec.rb | 10 +- .../partitioning_spec.rb | 29 +++ spec/services/git/branch_push_service_spec.rb | 6 +- .../merge_requests/update_service_spec.rb | 2 +- .../projects/update_pages_service_spec.rb | 19 ++ ...s_to_ghost_user_in_batches_service_spec.rb | 31 +++ ...rate_records_to_ghost_user_service_spec.rb | 3 +- spec/support/rspec_order_todo.yml | 5 - ...quest_draft_status_email.html.haml_spec.rb | 17 +- ...equest_draft_status_email.text.erb_spec.rb | 14 +- .../concerns/cluster_agent_queue_spec.rb | 1 - spec/workers/concerns/cluster_queue_spec.rb | 21 -- spec/workers/concerns/cronjob_queue_spec.rb | 4 - .../gitlab/github_import/queue_spec.rb | 18 -- .../pipeline_background_queue_spec.rb | 21 -- spec/workers/concerns/pipeline_queue_spec.rb | 21 -- .../concerns/repository_check_queue_spec.rb | 4 - spec/workers/concerns/waitable_worker_spec.rb | 3 +- spec/workers/every_sidekiq_worker_spec.rb | 3 + .../import_protected_branch_worker_spec.rb | 40 ++++ .../stage/import_attachments_worker_spec.rb | 5 +- .../import_protected_branches_worker_spec.rb | 58 +++++ spec/workers/issues/close_worker_spec.rb | 86 +++++++ spec/workers/process_commit_worker_spec.rb | 54 ++--- .../expired_notification_worker_spec.rb | 1 - .../expiring_soon_notification_worker_spec.rb | 1 - ...ds_to_ghost_user_in_batches_worker_spec.rb | 53 +++++ 90 files changed, 1829 insertions(+), 267 deletions(-) create mode 100644 app/services/users/migrate_records_to_ghost_user_in_batches_service.rb create mode 100644 app/workers/gitlab/github_import/import_protected_branch_worker.rb create mode 100644 app/workers/gitlab/github_import/stage/import_protected_branches_worker.rb create mode 100644 app/workers/issues/close_worker.rb create mode 100644 app/workers/users/migrate_records_to_ghost_user_in_batches_worker.rb create mode 100644 config/feature_flags/development/process_issue_closure_in_background.yml create mode 100644 config/feature_flags/development/user_destroy_with_limited_execution_time_worker.yml create mode 100644 config/metrics/counts_28d/20220825232557_count_user_auth.yml create mode 100644 lib/gitlab/audit/type/definition.rb create mode 100644 lib/gitlab/github_import/importer/protected_branch_importer.rb create mode 100644 lib/gitlab/github_import/importer/protected_branches_importer.rb create mode 100644 lib/gitlab/github_import/representation/protected_branch.rb create mode 100644 lib/gitlab/utils/execution_tracker.rb create mode 100644 spec/lib/gitlab/audit/type/definition_spec.rb create mode 100644 spec/lib/gitlab/github_import/importer/protected_branch_importer_spec.rb create mode 100644 spec/lib/gitlab/github_import/importer/protected_branches_importer_spec.rb create mode 100644 spec/lib/gitlab/github_import/representation/protected_branch_spec.rb create mode 100644 spec/lib/gitlab/utils/execution_tracker_spec.rb create mode 100644 spec/services/users/migrate_records_to_ghost_user_in_batches_service_spec.rb delete mode 100644 spec/workers/concerns/cluster_queue_spec.rb delete mode 100644 spec/workers/concerns/gitlab/github_import/queue_spec.rb delete mode 100644 spec/workers/concerns/pipeline_background_queue_spec.rb delete mode 100644 spec/workers/concerns/pipeline_queue_spec.rb create mode 100644 spec/workers/gitlab/github_import/import_protected_branch_worker_spec.rb create mode 100644 spec/workers/gitlab/github_import/stage/import_protected_branches_worker_spec.rb create mode 100644 spec/workers/issues/close_worker_spec.rb create mode 100644 spec/workers/users/migrate_records_to_ghost_user_in_batches_worker_spec.rb diff --git a/app/assets/javascripts/access_tokens/components/new_access_token_app.vue b/app/assets/javascripts/access_tokens/components/new_access_token_app.vue index 4098130335a..6b52bd84656 100644 --- a/app/assets/javascripts/access_tokens/components/new_access_token_app.vue +++ b/app/assets/javascripts/access_tokens/components/new_access_token_app.vue @@ -81,12 +81,14 @@ export default { this.infoAlert = createAlert({ message: this.alertInfoMessage, variant: VARIANT_INFO }); - // Reset all input fields except the datepicker. - this.form.querySelectorAll('input:not([id$=expires_at])').forEach((el) => { - // The form token creation is not controlled by Vue. - el.checked = false; + // Selectively reset all input fields except for the date picker and submit. + // The form token creation is not controlled by Vue. + this.form.querySelectorAll('input[type=text]:not([id$=expires_at])').forEach((el) => { el.value = ''; }); + this.form.querySelectorAll('input[type=checkbox]').forEach((el) => { + el.checked = false; + }); }, }, }; diff --git a/app/assets/javascripts/api.js b/app/assets/javascripts/api.js index 0c870a89760..b02dd9321b3 100644 --- a/app/assets/javascripts/api.js +++ b/app/assets/javascripts/api.js @@ -47,6 +47,7 @@ const Api = { projectSharePath: '/api/:version/projects/:id/share', projectMilestonesPath: '/api/:version/projects/:id/milestones', projectIssuePath: '/api/:version/projects/:id/issues/:issue_iid', + projectCreateIssuePath: '/api/:version/projects/:id/issues', mergeRequestsPath: '/api/:version/merge_requests', groupLabelsPath: '/api/:version/groups/:namespace_path/labels', issuableTemplatePath: '/:namespace_path/:project_path/templates/:type/:key', diff --git a/app/assets/javascripts/vue_merge_request_widget/components/state_container.vue b/app/assets/javascripts/vue_merge_request_widget/components/state_container.vue index f4850b712fa..822c5a68093 100644 --- a/app/assets/javascripts/vue_merge_request_widget/components/state_container.vue +++ b/app/assets/javascripts/vue_merge_request_widget/components/state_container.vue @@ -38,11 +38,18 @@ export default { expandDetailsTooltip: __('Expand merge details'), collapseDetailsTooltip: __('Collapse merge details'), }, + computed: { + wrapperClasses() { + if (this.status === 'merged') return 'gl-bg-blue-50'; + if (this.status === 'closed') return 'gl-bg-red-50'; + return null; + }, + }, };