From 17eaecd6c7cb33d0f171ae10da190fa120a817f3 Mon Sep 17 00:00:00 2001 From: Grzegorz Bizon Date: Mon, 23 May 2016 19:43:58 +0200 Subject: [PATCH] Enable Style/InfiniteLoop Rubocop cop --- .rubocop.yml | 2 +- app/models/network/graph.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.rubocop.yml b/.rubocop.yml index 0946ef5d848..3f5a7052694 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -299,7 +299,7 @@ Style/IndentHash: # Use Kernel#loop for infinite loops. Style/InfiniteLoop: - Enabled: false + Enabled: true # Use the new lambda literal syntax for single-line blocks. Style/Lambda: diff --git a/app/models/network/graph.rb b/app/models/network/graph.rb index f4e90125373..9259cb1a0fa 100644 --- a/app/models/network/graph.rb +++ b/app/models/network/graph.rb @@ -253,7 +253,7 @@ module Network leaves = [] leaves.push(commit) if commit.space.zero? - while true + loop do return leaves if commit.parents(@map).count.zero? commit = commit.parents(@map).first