kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Display loading indicator when filtering ref switcher dropdown

Browse source
This commit is contained in:
Clement Ho 2017-02-10 10:44:42 -06:00
parent 4a9258371b
commit 17f5a34bfd
3 changed files with 9 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/assets/javascripts/gl_dropdown.js
View file

@ -47,9 +47,11 @@
}
// Only filter asynchronously only if option remote is set
if (this.options.remote) {
$inputContainer.parent().addClass('is-loading');
clearTimeout(timeout);
return timeout = setTimeout(function() {
return this.options.query(this.input.val(), function(data) {
$inputContainer.parent().removeClass('is-loading');
return this.options.callback(data);
}.bind(this));
}.bind(this), 250);

4
changelogs/unreleased/27966-branch-ref-switcher-input-filter-broken.yml Normal file
View file

@ -0,0 +1,4 @@
---
title: Display loading indicator when filtering ref switcher dropdown
merge_request:
author:

6
spec/features/projects/ref_switcher_spec.rb
View file

@ -20,9 +20,9 @@ feature 'Ref switcher', feature: true, js: true do
input.set 'binary'
wait_for_ajax
input.native.send_keys :down
input.native.send_keys :down
input.native.send_keys :enter
page.within '.dropdown-content ul' do
input.native.send_keys :enter
end
end
expect(page).to have_title 'binary-encoding'