kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Check for all possible timeago strings that can be rendered in a few minutes. We cannot rely on 'less than a minute ago'

Browse source
This commit is contained in:
Luke "Jared" Bennett 2017-05-08 09:09:08 +00:00
parent 6386e42f06
commit 17fc18ec2c
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
spec/features/snippets/notes_on_personal_snippets_spec.rb
View file

@ -67,6 +67,9 @@ describe 'Comments on personal snippets', :js, feature: true do
end end
context 'when editing a note' do context 'when editing a note' do
# Matches `less than a minute ago`, `about a minute ago` and `N minutes ago`
let(:timeago_regex) { /((less than|about) a minute|\d+? minutes) ago/ }
it 'changes the text' do it 'changes the text' do
page.within("#notes-list li#note_#{snippet_notes[0].id}") do page.within("#notes-list li#note_#{snippet_notes[0].id}") do
click_on 'Edit comment' click_on 'Edit comment'
@ -80,7 +83,7 @@ describe 'Comments on personal snippets', :js, feature: true do
page.within("#notes-list li#note_#{snippet_notes[0].id}") do page.within("#notes-list li#note_#{snippet_notes[0].id}") do
expect(page).to have_css('.note_edited_ago') expect(page).to have_css('.note_edited_ago')
expect(page).to have_content('new content') expect(page).to have_content('new content')
expect(find('.note_edited_ago').text).to match(/less than a minute ago/) expect(find('.note_edited_ago').text).to match(timeago_regex)
end end
end end
end end