Link to the tag from a version instead of commit

This will result in a 404 when running an unreleased security patch
while still allowing users to find the commit when it is made available.
This commit is contained in:
Bob Van Landuyt 2018-10-01 10:43:46 +02:00
parent 272e1482d6
commit 1832426109
3 changed files with 7 additions and 3 deletions

View File

@ -7,8 +7,7 @@
GitLab
Community Edition
- if user_signed_in?
%span= Gitlab::VERSION
%small= link_to Gitlab.revision, Gitlab::COM_URL + namespace_project_commits_path('gitlab-org', 'gitlab-ce', Gitlab.revision)
%span= link_to Gitlab::VERSION, Gitlab::COM_URL + namespace_project_tag_path('gitlab-org', 'gitlab-ce', "v#{Gitlab::VERSION}")
= version_status_badge
%hr

View File

@ -0,0 +1,5 @@
---
title: Link to the tag for a version on the help page instead of to the commit
merge_request: 22015
author:
type: changed

View File

@ -21,7 +21,7 @@ describe 'help/index' do
render
expect(rendered).to match '8.0.2'
expect(rendered).to have_link('abcdefg', href: 'https://gitlab.com/gitlab-org/gitlab-ce/commits/abcdefg')
expect(rendered).to have_link('8.0.2', href: 'https://gitlab.com/gitlab-org/gitlab-ce/tags/v8.0.2')
end
end