kotovalexarian-likes-gitlab
/
gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Add code review remarks

This commit is contained in:
Małgorzata Ksionek 2019-09-10 11:51:37 +02:00
parent 8472fa0807
commit 18a4afc50e
1 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
lib/gitlab/i18n/po_linter.rb
View File

@ -170,16 +170,11 @@ module Gitlab
end
def translate_plural(entry)
used_plural_variables = entry.plural_id.scan(VARIABLE_REGEX)
plural_variables = fill_in_variables(used_plural_variables)
used_singular_variables = entry.msgid.scan(VARIABLE_REGEX)
singular_variables = fill_in_variables(used_singular_variables)
numbers_covering_all_plurals.map do |number|
translation = FastGettext::Translation.n_(entry.msgid, entry.plural_id, number)
index = index_for_pluralization(number)
variables = index == 0 ? singular_variables : plural_variables
used_variables = index == 0 ? entry.msgid.scan(VARIABLE_REGEX) : entry.plural_id.scan(VARIABLE_REGEX)
variables = fill_in_variables(used_variables)
translation % variables if variables.any?
end