From 18b54e46b77786995acdb1026c2ec35956e33780 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Wed, 11 May 2022 06:08:03 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .rubocop_todo.yml | 5 - .rubocop_todo/style/hash_each_methods.yml | 91 +++++++++++++++++++ .../components/value_stream_metrics.vue | 5 +- .../javascripts/analytics/shared/constants.js | 27 +++++- .../forms/components/integration_form.vue | 2 +- .../pipelines/components/dag/dag.vue | 2 +- app/controllers/graphql_controller.rb | 2 +- .../clusters/clusters/_integrations.html.haml | 4 +- .../merge_requests/_mr_title.html.haml | 14 +-- .../concerns/git_garbage_collect_methods.rb | 18 +++- .../projects/git_garbage_collect_worker.rb | 8 +- .../wikis/git_garbage_collect_worker.rb | 8 +- db/docs/ci_deleted_objects.yml | 2 +- db/docs/ci_unit_tests.yml | 2 +- db/docs/reviews.yml | 2 +- doc/user/clusters/agent/index.md | 1 + .../DAST-Default-Branch-Deploy.gitlab-ci.yml | 2 +- .../ci/templates/Jobs/Deploy.gitlab-ci.yml | 2 +- .../Jobs/Deploy.latest.gitlab-ci.yml | 2 +- .../Security/Container-Scanning.gitlab-ci.yml | 4 +- locale/gitlab.pot | 39 ++++++++ .../nuget/nuget_project_level_spec.rb | 9 +- .../graphql/project/merge_requests_spec.rb | 2 +- .../ci/create_pipeline_service_spec.rb | 2 +- spec/support/helpers/graphql_helpers.rb | 6 +- ...garbage_collect_methods_shared_examples.rb | 2 + 26 files changed, 218 insertions(+), 45 deletions(-) create mode 100644 .rubocop_todo/style/hash_each_methods.yml diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 3f495ef85b2..178311bbc95 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -199,11 +199,6 @@ Style/FormatString: Style/HashAsLastArrayItem: Enabled: false -# Offense count: 70 -# Cop supports --auto-correct. -Style/HashEachMethods: - Enabled: false - # Offense count: 64 # Cop supports --auto-correct. Style/KeywordParametersOrder: diff --git a/.rubocop_todo/style/hash_each_methods.yml b/.rubocop_todo/style/hash_each_methods.yml new file mode 100644 index 00000000000..648b6fbbe08 --- /dev/null +++ b/.rubocop_todo/style/hash_each_methods.yml @@ -0,0 +1,91 @@ +--- +# Cop supports --auto-correct. +Style/HashEachMethods: + # Offense count: 95 + # Temporarily disabled due to too many offenses + Enabled: false + Exclude: + - 'app/graphql/resolvers/concerns/caching_array_resolver.rb' + - 'app/graphql/types/alert_management/severity_enum.rb' + - 'app/graphql/types/availability_enum.rb' + - 'app/graphql/types/ci/code_quality_degradation_severity_enum.rb' + - 'app/graphql/types/ci/job_artifact_file_type_enum.rb' + - 'app/graphql/types/ci/pipeline_config_source_enum.rb' + - 'app/graphql/types/ci/runner_access_level_enum.rb' + - 'app/graphql/types/clusters/agent_token_status_enum.rb' + - 'app/graphql/types/container_repository_status_enum.rb' + - 'app/graphql/types/data_visualization_palette/color_enum.rb' + - 'app/graphql/types/data_visualization_palette/weight_enum.rb' + - 'app/graphql/types/dependency_proxy/manifest_type_enum.rb' + - 'app/graphql/types/design_management/design_collection_copy_state_enum.rb' + - 'app/graphql/types/design_management/design_version_event_enum.rb' + - 'app/graphql/types/event_action_enum.rb' + - 'app/graphql/types/issuable_severity_enum.rb' + - 'app/graphql/types/packages/conan/metadatum_file_type_enum.rb' + - 'app/graphql/types/packages/package_dependency_type_enum.rb' + - 'app/graphql/types/packages/package_status_enum.rb' + - 'app/graphql/types/packages/package_type_enum.rb' + - 'app/graphql/types/release_asset_link_type_enum.rb' + - 'app/graphql/types/user_callout_feature_name_enum.rb' + - 'app/helpers/routing/pseudonymization_helper.rb' + - 'app/models/application_setting.rb' + - 'app/services/security/merge_reports_service.rb' + - 'config/initializers/6_validations.rb' + - 'config/initializers/8_gitaly.rb' + - 'ee/app/graphql/types/compliance_management/merge_requests/compliance_violation_reason_enum.rb' + - 'ee/app/graphql/types/compliance_management/merge_requests/compliance_violation_severity_enum.rb' + - 'ee/app/graphql/types/incident_management/oncall_rotation_length_unit_enum.rb' + - 'ee/app/graphql/types/security_report_summary_type.rb' + - 'ee/app/graphql/types/vulnerabilities_count_by_day_type.rb' + - 'ee/app/graphql/types/vulnerability/external_issue_link_external_tracker_enum.rb' + - 'ee/app/graphql/types/vulnerability/external_issue_link_type_enum.rb' + - 'ee/app/graphql/types/vulnerability/issue_link_type_enum.rb' + - 'ee/app/graphql/types/vulnerability_confidence_enum.rb' + - 'ee/app/graphql/types/vulnerability_grade_enum.rb' + - 'ee/app/graphql/types/vulnerability_report_type_enum.rb' + - 'ee/app/graphql/types/vulnerability_severities_count_type.rb' + - 'ee/app/graphql/types/vulnerability_severity_enum.rb' + - 'ee/app/models/geo/secondary_usage_data.rb' + - 'ee/db/fixtures/development/32_compliance_report_violations.rb' + - 'ee/lib/gitlab/ci/reports/license_scanning/report.rb' + - 'ee/spec/factories/vulnerabilities.rb' + - 'ee/spec/factories/vulnerabilities/findings.rb' + - 'ee/spec/helpers/application_helper_spec.rb' + - 'ee/spec/lib/gitlab/geo_spec.rb' + - 'lib/api/todos.rb' + - 'lib/backup/manager.rb' + - 'lib/gitlab/changelog/release.rb' + - 'lib/gitlab/ci/parsers.rb' + - 'lib/gitlab/ci/reports/test_suite.rb' + - 'lib/gitlab/metrics/samplers/ruby_sampler.rb' + - 'lib/gitlab/metrics/subscribers/active_record.rb' + - 'lib/gitlab/metrics/subscribers/load_balancing.rb' + - 'lib/gitlab/middleware/multipart.rb' + - 'lib/gitlab/sidekiq_middleware/duplicate_jobs/duplicate_job.rb' + - 'lib/gitlab/usage_data.rb' + - 'spec/controllers/projects_controller_spec.rb' + - 'spec/factories/ci/reports/codequality_degradations.rb' + - 'spec/finders/packages/group_packages_finder_spec.rb' + - 'spec/helpers/application_helper_spec.rb' + - 'spec/lib/gitlab/ci/status/build/failed_spec.rb' + - 'spec/lib/gitlab/metrics/samplers/ruby_sampler_spec.rb' + - 'spec/lib/gitlab/template/gitlab_ci_yml_template_spec.rb' + - 'spec/lib/gitlab/usage_data_spec.rb' + - 'spec/models/ci/build_spec.rb' + - 'spec/models/ci/job_artifact_spec.rb' + - 'spec/models/ci/resource_group_spec.rb' + - 'spec/models/clusters/cluster_spec.rb' + - 'spec/models/concerns/has_user_type_spec.rb' + - 'spec/models/packages/package_spec.rb' + - 'spec/models/user_spec.rb' + - 'spec/presenters/ci/pipeline_presenter_spec.rb' + - 'spec/presenters/commit_status_presenter_spec.rb' + - 'spec/presenters/packages/npm/package_presenter_spec.rb' + - 'spec/services/system_notes/incident_service_spec.rb' + - 'spec/support/helpers/multipart_helpers.rb' + - 'spec/support/helpers/reactive_caching_helpers.rb' + - 'spec/support/import_export/project_tree_expectations.rb' + - 'spec/support/shared_examples/requests/api/npm_packages_shared_examples.rb' + - 'spec/support/shared_examples/services/packages_shared_examples.rb' + - 'spec/tasks/gitlab/packages/events_rake_spec.rb' + - 'tooling/graphql/docs/helper.rb' diff --git a/app/assets/javascripts/analytics/shared/components/value_stream_metrics.vue b/app/assets/javascripts/analytics/shared/components/value_stream_metrics.vue index acc82761e88..6ac1bce4032 100644 --- a/app/assets/javascripts/analytics/shared/components/value_stream_metrics.vue +++ b/app/assets/javascripts/analytics/shared/components/value_stream_metrics.vue @@ -1,6 +1,6 @@