Merge branch 'fix-anchor-bug' into 'master'

Fix anchor bug

Fixes #1886

See merge request !1395

app/assets/stylesheets/generic/timeline.scss

@@ -20,6 +20,17 @@
     margin-bottom: 10px;
     clear: both;
 
+    /* Hack for anchors and fixed navbar */
+    &[id] {
+      &:before {
+        content: '';
+        display: block;
+        position: relative;
+        width: 0;
+        height: 3em;
+        margin-top: -3em;
+      }
+    }
 
     &:target {
       .timeline-entry-inner .timeline-content {

app/assets/stylesheets/generic/typography.scss

@@ -98,8 +98,7 @@ a:focus {
       $size: 16px;
       position: absolute;
       right: 100%;
-      top: 50%;
-      margin-top: -$size/2;
+      bottom: 7px;
       margin-right: 0px;
       padding-right: 20px;
       display: inline-block;
@@ -109,6 +108,18 @@ a:focus {
       background-size: contain;
       background-repeat: no-repeat;
     }
+
+    /* Hack for anchors and fixed navbar */
+    &[id] {
+      &:before {
+        content: '';
+        display: block;
+        position: relative;
+        width: 0;
+        height: 3em;
+        margin-top: -3em;
+      }
+    }
   }
 
   ul {

app/assets/stylesheets/main/layout.scss

@@ -12,4 +12,3 @@ html {
 .container .content {
   margin: 0 0;
 }
-

app/assets/stylesheets/main/mixins.scss

@@ -65,8 +65,10 @@
     max-width: 100%;
   }
 
-  *:first-child {
-    margin-top: 0;
+  h1, h2, h3 {
+    &:first-child {
+      margin-top: 0;
+    }
   }
 
   code { padding: 0 4px; }

app/assets/stylesheets/sections/header.scss

@@ -8,8 +8,6 @@ header {
     margin-bottom: 0;
     min-height: 40px;
     border: none;
-    position: fixed;
-    top: 0;
     width: 100%;
 
     .navbar-inner {

app/assets/stylesheets/sections/notes.scss

@@ -57,6 +57,7 @@ ul.notes {
   .note {
     display: block;
     position:relative;
+
     .attachment {
       font-size: 14px;
     }

app/views/layouts/_head_panel.html.haml

@@ -1,4 +1,4 @@
-%header.navbar.navbar-static-top.navbar-gitlab
+%header.navbar.navbar-fixed-top.navbar-gitlab
   .navbar-inner
     .container
       %div.app_logo

features/steps/shared/issuable.rb

@@ -2,7 +2,7 @@ module SharedIssuable
   include Spinach::DSL
 
   def edit_issuable
-   find(:css, '.issuable-edit').click
+    find(:css, '.issuable-edit').trigger('click')
   end
 
   step 'I click link "Edit" for the merge request' do