kotovalexarian-likes-gitlab
/
gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Remove unnecessary comments

This commit is contained in:
Douwe Maan 2017-09-25 10:23:43 +02:00
parent 91b40b3bab
commit 19a30595d9
2 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/models/commit.rb
View File

@ -25,7 +25,6 @@ class Commit
DIFF_HARD_LIMIT_FILES = 1000
DIFF_HARD_LIMIT_LINES = 50000
# The SHA can be between 7 and 40 hex characters.
MIN_SHA_LENGTH = 7
COMMIT_SHA_PATTERN = /\h{#{MIN_SHA_LENGTH},40}/.freeze
@ -217,7 +216,6 @@ class Commit
@raw.respond_to?(method, include_private) || super
end
# Truncate sha to 7 characters
def short_id
@raw.short_id(MIN_SHA_LENGTH)
end

4
lib/gitlab/diff/diff_refs.rb
View File

@ -57,8 +57,8 @@ module Gitlab
length = [sha1.length, sha2.length].min
# If either of the shas is below 7 characters in length, we cannot be sure
# if they actually refer to the same commit because of hash collision.
# If either of the shas is below the minimum length, we cannot be sure
# that they actually refer to the same commit because of hash collision.
return false if length < Commit::MIN_SHA_LENGTH
sha1[0, length] == sha2[0, length]