From b69d7ac3c9de7b0ba3e60ede70f1de630a53dfe6 Mon Sep 17 00:00:00 2001
From: Phil Hughes <me@iamphill.com>
Date: Thu, 11 Jan 2018 12:38:30 +0000
Subject: [PATCH 1/5] Added dispatcher imports for some project routes

---
 app/assets/javascripts/dispatcher.js          |  48 ++------
 .../javascripts/pages/projects/edit/index.js  |   6 +
 .../javascripts/pages/projects/index.js       |   7 ++
 .../javascripts/pages/projects/new/index.js   |   7 ++
 .../{ => pages/projects}/project.js           |   4 +-
 .../components/project_feature_setting.vue    |   2 +-
 .../components/project_setting_row.vue        |   0
 .../permissions/components/settings_panel.vue |   2 +-
 .../projects/shared}/permissions/constants.js |   0
 .../projects/shared}/permissions/external.js  |   0
 .../projects/shared}/permissions/index.js     |   0
 .../projects/shared}/project_avatar.js        |   0
 .../projects/shared}/project_new.js           |   2 +-
 .../javascripts/pages/projects/wikis/index.js |  11 ++
 .../{ => pages/projects/wikis}/wikis.js       |   4 +-
 .../javascripts/projects/project_new.js       | 108 ------------------
 .../mr_widget_options.js                      |   2 +-
 app/views/projects/new.html.haml              |   2 -
 config/webpack.config.js                      |   1 -
 spec/javascripts/projects/project_new_spec.js |   2 +-
 20 files changed, 52 insertions(+), 156 deletions(-)
 create mode 100644 app/assets/javascripts/pages/projects/index.js
 create mode 100644 app/assets/javascripts/pages/projects/new/index.js
 rename app/assets/javascripts/{ => pages/projects}/project.js (97%)
 rename app/assets/javascripts/{projects => pages/projects/shared}/permissions/components/project_feature_setting.vue (96%)
 rename app/assets/javascripts/{projects => pages/projects/shared}/permissions/components/project_setting_row.vue (100%)
 rename app/assets/javascripts/{projects => pages/projects/shared}/permissions/components/settings_panel.vue (99%)
 rename app/assets/javascripts/{projects => pages/projects/shared}/permissions/constants.js (100%)
 rename app/assets/javascripts/{projects => pages/projects/shared}/permissions/external.js (100%)
 rename app/assets/javascripts/{projects => pages/projects/shared}/permissions/index.js (100%)
 rename app/assets/javascripts/{ => pages/projects/shared}/project_avatar.js (100%)
 rename app/assets/javascripts/{ => pages/projects/shared}/project_new.js (98%)
 create mode 100644 app/assets/javascripts/pages/projects/wikis/index.js
 rename app/assets/javascripts/{ => pages/projects/wikis}/wikis.js (94%)
 delete mode 100644 app/assets/javascripts/projects/project_new.js

diff --git a/app/assets/javascripts/dispatcher.js b/app/assets/javascripts/dispatcher.js
index 1c6336073e9..5609553a51c 100644
--- a/app/assets/javascripts/dispatcher.js
+++ b/app/assets/javascripts/dispatcher.js
@@ -9,11 +9,8 @@ import notificationsDropdown from './notifications_dropdown';
 import groupAvatar from './group_avatar';
 import GroupLabelSubscription from './group_label_subscription';
 import LineHighlighter from './line_highlighter';
-import Project from './project';
-import projectAvatar from './project_avatar';
 import MergeRequest from './merge_request';
 import Compare from './compare';
-import ProjectNew from './project_new';
 import Labels from './labels';
 import LabelManager from './label_manager';
 import Sidebar from './right_sidebar';
@@ -24,20 +21,17 @@ import SecretValues from './behaviors/secret_values';
 import Group from './group';
 import ProjectsList from './projects_list';
 import UserCallout from './user_callout';
-import ShortcutsWiki from './shortcuts_wiki';
 import BlobViewer from './blob/viewer/index';
 import AutoWidthDropdownSelect from './issuable/auto_width_dropdown_select';
 import UsersSelect from './users_select';
 import GfmAutoComplete from './gfm_auto_complete';
 import Star from './star';
 import TreeView from './tree';
-import Wikis from './wikis';
 import ZenMode from './zen_mode';
 import initSettingsPanels from './settings_panels';
 import PerformanceBar from './performance_bar';
 import initNotes from './init_notes';
 import initIssuableSidebar from './init_issuable_sidebar';
-import initProjectVisibilitySelector from './project_visibility';
 import NewGroupChild from './groups/new_group_child';
 import { ajaxGet, convertPermissionToBoolean } from './lib/utils/common_utils';
 import GlFieldErrors from './gl_field_errors';
@@ -70,7 +64,7 @@ import Activities from './activities';
         return false;
       }
 
-      const fail = () => Flash('Error loading dynamic module');
+      const fail = (e) => { throw e; Flash('Error loading dynamic module'); }
       const callDefault = m => m.default();
 
       path = page.split(':');
@@ -642,57 +636,39 @@ import Activities from './activities';
             .catch(fail);
           break;
         case 'projects':
-          new Project();
-          projectAvatar();
+          import('./pages/projects')
+            .then(callDefault)
+            .catch(fail);
+          shortcut_handler = true;
           switch (path[1]) {
             case 'compare':
               import('./pages/projects/compare')
                 .then(callDefault)
                 .catch(fail);
               break;
-            case 'edit':
-              shortcut_handler = new ShortcutsNavigation();
-              new ProjectNew();
-              import(/* webpackChunkName: 'project_permissions' */ './projects/permissions')
+            case 'create':
+            case 'new':
+              import('./pages/projects/new')
                 .then(callDefault)
                 .catch(fail);
               break;
-            case 'new':
-              new ProjectNew();
-              initProjectVisibilitySelector();
-              break;
             case 'show':
               new Star();
-              new ProjectNew();
               notificationsDropdown();
               break;
             case 'wikis':
-              new Wikis();
-              shortcut_handler = new ShortcutsWiki();
-              new ZenMode();
-              new GLForm($('.wiki-form'), true);
+              import('./pages/projects/wikis')
+                .then(callDefault)
+                .catch(fail);
+              shortcut_handler = true;
               break;
             case 'snippets':
-              shortcut_handler = new ShortcutsNavigation();
               if (path[2] === 'show') {
                 new ZenMode();
                 new LineHighlighter();
                 new BlobViewer();
               }
               break;
-            case 'labels':
-            case 'graphs':
-            case 'compare':
-            case 'pipelines':
-            case 'forks':
-            case 'milestones':
-            case 'project_members':
-            case 'deploy_keys':
-            case 'builds':
-            case 'hooks':
-            case 'services':
-            case 'protected_branches':
-              shortcut_handler = new ShortcutsNavigation();
           }
           break;
       }
diff --git a/app/assets/javascripts/pages/projects/edit/index.js b/app/assets/javascripts/pages/projects/edit/index.js
index 7f662ef6b6a..9edf36d66b1 100644
--- a/app/assets/javascripts/pages/projects/edit/index.js
+++ b/app/assets/javascripts/pages/projects/edit/index.js
@@ -1,8 +1,14 @@
 import initSettingsPanels from '~/settings_panels';
 import setupProjectEdit from '~/project_edit';
+import ProjectNew from '../shared/project_new';
+import projectAvatar from '../shared/project_avatar';
+import initProjectPermissionsSettings from '../shared/permissions';
 
 export default () => {
+  new ProjectNew(); // eslint-disable-line no-new
   setupProjectEdit();
   // Initialize expandable settings panels
   initSettingsPanels();
+  projectAvatar();
+  initProjectPermissionsSettings();
 };
diff --git a/app/assets/javascripts/pages/projects/index.js b/app/assets/javascripts/pages/projects/index.js
new file mode 100644
index 00000000000..9b1d52692a3
--- /dev/null
+++ b/app/assets/javascripts/pages/projects/index.js
@@ -0,0 +1,7 @@
+import Project from './project';
+import ShortcutsNavigation from '../../shortcuts_navigation';
+
+export default () => {
+  new Project(); // eslint-disable-line no-new
+  new ShortcutsNavigation(); // eslint-disable-line no-new
+};
diff --git a/app/assets/javascripts/pages/projects/new/index.js b/app/assets/javascripts/pages/projects/new/index.js
new file mode 100644
index 00000000000..45951461779
--- /dev/null
+++ b/app/assets/javascripts/pages/projects/new/index.js
@@ -0,0 +1,7 @@
+import ProjectNew from '../shared/project_new';
+import initProjectVisibilitySelector from '../../../project_visibility';
+
+export default () => {
+  new ProjectNew(); // eslint-disable-line no-new
+  initProjectVisibilitySelector();
+};
diff --git a/app/assets/javascripts/project.js b/app/assets/javascripts/pages/projects/project.js
similarity index 97%
rename from app/assets/javascripts/project.js
rename to app/assets/javascripts/pages/projects/project.js
index d4f26b81f30..e30d558726b 100644
--- a/app/assets/javascripts/project.js
+++ b/app/assets/javascripts/pages/projects/project.js
@@ -1,8 +1,8 @@
 /* eslint-disable func-names, space-before-function-paren, no-var, consistent-return, no-new, prefer-arrow-callback, no-return-assign, one-var, one-var-declaration-per-line, object-shorthand, no-else-return, newline-per-chained-call, no-shadow, vars-on-top, prefer-template, max-len */
 
 import Cookies from 'js-cookie';
-import { visitUrl } from './lib/utils/url_utility';
-import projectSelect from './project_select';
+import { visitUrl } from '../../lib/utils/url_utility';
+import projectSelect from '../../project_select';
 
 export default class Project {
   constructor() {
diff --git a/app/assets/javascripts/projects/permissions/components/project_feature_setting.vue b/app/assets/javascripts/pages/projects/shared/permissions/components/project_feature_setting.vue
similarity index 96%
rename from app/assets/javascripts/projects/permissions/components/project_feature_setting.vue
rename to app/assets/javascripts/pages/projects/shared/permissions/components/project_feature_setting.vue
index 3ebfe82597a..9b13b2a524f 100644
--- a/app/assets/javascripts/projects/permissions/components/project_feature_setting.vue
+++ b/app/assets/javascripts/pages/projects/shared/permissions/components/project_feature_setting.vue
@@ -1,5 +1,5 @@
 <script>
-  import projectFeatureToggle from '../../../vue_shared/components/toggle_button.vue';
+  import projectFeatureToggle from '../../../../../vue_shared/components/toggle_button.vue';
 
   export default {
     components: {
diff --git a/app/assets/javascripts/projects/permissions/components/project_setting_row.vue b/app/assets/javascripts/pages/projects/shared/permissions/components/project_setting_row.vue
similarity index 100%
rename from app/assets/javascripts/projects/permissions/components/project_setting_row.vue
rename to app/assets/javascripts/pages/projects/shared/permissions/components/project_setting_row.vue
diff --git a/app/assets/javascripts/projects/permissions/components/settings_panel.vue b/app/assets/javascripts/pages/projects/shared/permissions/components/settings_panel.vue
similarity index 99%
rename from app/assets/javascripts/projects/permissions/components/settings_panel.vue
rename to app/assets/javascripts/pages/projects/shared/permissions/components/settings_panel.vue
index c96ce12d9fb..380c6c3ea7d 100644
--- a/app/assets/javascripts/projects/permissions/components/settings_panel.vue
+++ b/app/assets/javascripts/pages/projects/shared/permissions/components/settings_panel.vue
@@ -1,6 +1,6 @@
 <script>
   import projectFeatureSetting from './project_feature_setting.vue';
-  import projectFeatureToggle from '../../../vue_shared/components/toggle_button.vue';
+  import projectFeatureToggle from '../../../../../vue_shared/components/toggle_button.vue';
   import projectSettingRow from './project_setting_row.vue';
   import { visibilityOptions, visibilityLevelDescriptions } from '../constants';
   import { toggleHiddenClassBySelector } from '../external';
diff --git a/app/assets/javascripts/projects/permissions/constants.js b/app/assets/javascripts/pages/projects/shared/permissions/constants.js
similarity index 100%
rename from app/assets/javascripts/projects/permissions/constants.js
rename to app/assets/javascripts/pages/projects/shared/permissions/constants.js
diff --git a/app/assets/javascripts/projects/permissions/external.js b/app/assets/javascripts/pages/projects/shared/permissions/external.js
similarity index 100%
rename from app/assets/javascripts/projects/permissions/external.js
rename to app/assets/javascripts/pages/projects/shared/permissions/external.js
diff --git a/app/assets/javascripts/projects/permissions/index.js b/app/assets/javascripts/pages/projects/shared/permissions/index.js
similarity index 100%
rename from app/assets/javascripts/projects/permissions/index.js
rename to app/assets/javascripts/pages/projects/shared/permissions/index.js
diff --git a/app/assets/javascripts/project_avatar.js b/app/assets/javascripts/pages/projects/shared/project_avatar.js
similarity index 100%
rename from app/assets/javascripts/project_avatar.js
rename to app/assets/javascripts/pages/projects/shared/project_avatar.js
diff --git a/app/assets/javascripts/project_new.js b/app/assets/javascripts/pages/projects/shared/project_new.js
similarity index 98%
rename from app/assets/javascripts/project_new.js
rename to app/assets/javascripts/pages/projects/shared/project_new.js
index ca548d011b6..86faba0b910 100644
--- a/app/assets/javascripts/project_new.js
+++ b/app/assets/javascripts/pages/projects/shared/project_new.js
@@ -1,6 +1,6 @@
 /* eslint-disable func-names, no-var, no-underscore-dangle, prefer-template, prefer-arrow-callback*/
 
-import VisibilitySelect from './visibility_select';
+import VisibilitySelect from '../../../visibility_select';
 
 function highlightChanges($elm) {
   $elm.addClass('highlight-changes');
diff --git a/app/assets/javascripts/pages/projects/wikis/index.js b/app/assets/javascripts/pages/projects/wikis/index.js
new file mode 100644
index 00000000000..eb14c7a0e78
--- /dev/null
+++ b/app/assets/javascripts/pages/projects/wikis/index.js
@@ -0,0 +1,11 @@
+import Wikis from './wikis';
+import ShortcutsWiki from '../../../shortcuts_wiki';
+import ZenMode from '../../../zen_mode';
+import GLForm from '../../../gl_form';
+
+export default () => {
+  new Wikis(); // eslint-disable-line no-new
+  new ShortcutsWiki(); // eslint-disable-line no-new
+  new ZenMode(); // eslint-disable-line no-new
+  new GLForm($('.wiki-form'), true); // eslint-disable-line no-new
+};
diff --git a/app/assets/javascripts/wikis.js b/app/assets/javascripts/pages/projects/wikis/wikis.js
similarity index 94%
rename from app/assets/javascripts/wikis.js
rename to app/assets/javascripts/pages/projects/wikis/wikis.js
index 7a865587444..34a12ef76a1 100644
--- a/app/assets/javascripts/wikis.js
+++ b/app/assets/javascripts/pages/projects/wikis/wikis.js
@@ -1,5 +1,5 @@
-import bp from './breakpoints';
-import { slugify } from './lib/utils/text_utility';
+import bp from '../../../breakpoints';
+import { slugify } from '../../../lib/utils/text_utility';
 
 export default class Wikis {
   constructor() {
diff --git a/app/assets/javascripts/projects/project_new.js b/app/assets/javascripts/projects/project_new.js
deleted file mode 100644
index 4710e70d619..00000000000
--- a/app/assets/javascripts/projects/project_new.js
+++ /dev/null
@@ -1,108 +0,0 @@
-let hasUserDefinedProjectPath = false;
-
-const deriveProjectPathFromUrl = ($projectImportUrl) => {
-  const $currentProjectPath = $projectImportUrl.parents('.toggle-import-form').find('#project_path');
-  if (hasUserDefinedProjectPath) {
-    return;
-  }
-
-  let importUrl = $projectImportUrl.val().trim();
-  if (importUrl.length === 0) {
-    return;
-  }
-
-  /*
-    \/?: remove trailing slash
-    (\.git\/?)?: remove trailing .git (with optional trailing slash)
-    (\?.*)?: remove query string
-    (#.*)?: remove fragment identifier
-  */
-  importUrl = importUrl.replace(/\/?(\.git\/?)?(\?.*)?(#.*)?$/, '');
-
-  // extract everything after the last slash
-  const pathMatch = /\/([^/]+)$/.exec(importUrl);
-  if (pathMatch) {
-    $currentProjectPath.val(pathMatch[1]);
-  }
-};
-
-const bindEvents = () => {
-  const $newProjectForm = $('#new_project');
-  const $projectImportUrl = $('#project_import_url');
-  const $projectPath = $('#project_path');
-  const $useTemplateBtn = $('.template-button > input');
-  const $projectFieldsForm = $('.project-fields-form');
-  const $selectedTemplateText = $('.selected-template');
-  const $changeTemplateBtn = $('.change-template');
-  const $selectedIcon = $('.selected-icon svg');
-  const $templateProjectNameInput = $('#template-project-name #project_path');
-
-  if ($newProjectForm.length !== 1) {
-    return;
-  }
-
-  $('.how_to_import_link').on('click', (e) => {
-    e.preventDefault();
-    $(e.currentTarget).next('.modal').show();
-  });
-
-  $('.modal-header .close').on('click', () => {
-    $('.modal').hide();
-  });
-
-  $('.btn_import_gitlab_project').on('click', () => {
-    const importHref = $('a.btn_import_gitlab_project').attr('href');
-    $('.btn_import_gitlab_project').attr('href', `${importHref}?namespace_id=${$('#project_namespace_id').val()}&path=${$projectPath.val()}`);
-  });
-
-  function chooseTemplate() {
-    $('.template-option').hide();
-    $projectFieldsForm.addClass('selected');
-    $selectedIcon.removeClass('active');
-    const value = $(this).val();
-    const templates = {
-      rails: {
-        text: 'Ruby on Rails',
-        icon: '.selected-icon .icon-rails',
-      },
-      express: {
-        text: 'NodeJS Express',
-        icon: '.selected-icon .icon-node-express',
-      },
-      spring: {
-        text: 'Spring',
-        icon: '.selected-icon .icon-java-spring',
-      },
-    };
-
-    const selectedTemplate = templates[value];
-    $selectedTemplateText.text(selectedTemplate.text);
-    $(selectedTemplate.icon).addClass('active');
-    $templateProjectNameInput.focus();
-  }
-
-  $useTemplateBtn.on('change', chooseTemplate);
-
-  $changeTemplateBtn.on('click', () => {
-    $('.template-option').show();
-    $projectFieldsForm.removeClass('selected');
-    $useTemplateBtn.prop('checked', false);
-  });
-
-  $newProjectForm.on('submit', () => {
-    $projectPath.val($projectPath.val().trim());
-  });
-
-  $projectPath.on('keyup', () => {
-    hasUserDefinedProjectPath = $projectPath.val().trim().length > 0;
-  });
-
-  $projectImportUrl.keyup(() => deriveProjectPathFromUrl($projectImportUrl));
-};
-
-document.addEventListener('DOMContentLoaded', bindEvents);
-
-export default {
-  bindEvents,
-  deriveProjectPathFromUrl,
-};
diff --git a/app/assets/javascripts/vue_merge_request_widget/mr_widget_options.js b/app/assets/javascripts/vue_merge_request_widget/mr_widget_options.js
index 2075f8e4fec..98d33f9efaa 100644
--- a/app/assets/javascripts/vue_merge_request_widget/mr_widget_options.js
+++ b/app/assets/javascripts/vue_merge_request_widget/mr_widget_options.js
@@ -1,4 +1,4 @@
-import Project from '~/project';
+import Project from '~/pages/projects/project';
 import SmartInterval from '~/smart_interval';
 import Flash from '../flash';
 import {
diff --git a/app/views/projects/new.html.haml b/app/views/projects/new.html.haml
index 2f56630c22e..61ae0ebbce6 100644
--- a/app/views/projects/new.html.haml
+++ b/app/views/projects/new.html.haml
@@ -4,8 +4,6 @@
 - page_title    'New Project'
 - header_title  "Projects", dashboard_projects_path
 - visibility_level = params.dig(:project, :visibility_level) || default_project_visibility
-- content_for :page_specific_javascripts do
-  = webpack_bundle_tag 'project_new'
 
 .project-edit-container
   .project-edit-errors
diff --git a/config/webpack.config.js b/config/webpack.config.js
index 95fa79990e2..23784dd2a29 100644
--- a/config/webpack.config.js
+++ b/config/webpack.config.js
@@ -66,7 +66,6 @@ var config = {
     pipelines_times:      './pipelines/pipelines_times.js',
     profile:              './profile/profile_bundle.js',
     project_import_gl:    './projects/project_import_gitlab_project.js',
-    project_new:          './projects/project_new.js',
     prometheus_metrics:   './prometheus_metrics',
     protected_branches:   './protected_branches',
     protected_tags:       './protected_tags',
diff --git a/spec/javascripts/projects/project_new_spec.js b/spec/javascripts/projects/project_new_spec.js
index c314ca8ab72..a95fe83e60e 100644
--- a/spec/javascripts/projects/project_new_spec.js
+++ b/spec/javascripts/projects/project_new_spec.js
@@ -1,4 +1,4 @@
-import projectNew from '~/projects/project_new';
+import projectNew from '~/pages/projects/shared/project_new';
 
 describe('New Project', () => {
   let $projectImportUrl;

From 4ee29e897d38b1d8b31fce8d197270265a0a6f72 Mon Sep 17 00:00:00 2001
From: Phil Hughes <me@iamphill.com>
Date: Fri, 12 Jan 2018 13:18:53 +0000
Subject: [PATCH 2/5] fixed shortcuts not working on some pages

---
 app/assets/javascripts/dispatcher.js         | 2 +-
 app/assets/javascripts/shortcuts.js          | 6 ++----
 app/assets/javascripts/shortcuts_issuable.js | 4 ++--
 3 files changed, 5 insertions(+), 7 deletions(-)

diff --git a/app/assets/javascripts/dispatcher.js b/app/assets/javascripts/dispatcher.js
index 5609553a51c..1e8d693093f 100644
--- a/app/assets/javascripts/dispatcher.js
+++ b/app/assets/javascripts/dispatcher.js
@@ -302,7 +302,7 @@ import Activities from './activities';
           window.mergeRequest = new MergeRequest({
             action: mrShowNode.dataset.mrAction,
           });
-
+          console.log('asd');
           shortcut_handler = new ShortcutsIssuable(true);
           break;
         case 'dashboard:activity':
diff --git a/app/assets/javascripts/shortcuts.js b/app/assets/javascripts/shortcuts.js
index d2f0d7410da..35a3f05c980 100644
--- a/app/assets/javascripts/shortcuts.js
+++ b/app/assets/javascripts/shortcuts.js
@@ -13,12 +13,10 @@ Mousetrap.stopCallback = (e, element, combo) => {
 };
 
 export default class Shortcuts {
-  constructor(skipResetBindings) {
+  constructor() {
     this.onToggleHelp = this.onToggleHelp.bind(this);
     this.enabledHelp = [];
-    if (!skipResetBindings) {
-      Mousetrap.reset();
-    }
+
     Mousetrap.bind('?', this.onToggleHelp);
     Mousetrap.bind('s', Shortcuts.focusSearch);
     Mousetrap.bind('f', this.focusFilter.bind(this));
diff --git a/app/assets/javascripts/shortcuts_issuable.js b/app/assets/javascripts/shortcuts_issuable.js
index 6aeae84cdc5..689befc742e 100644
--- a/app/assets/javascripts/shortcuts_issuable.js
+++ b/app/assets/javascripts/shortcuts_issuable.js
@@ -1,10 +1,10 @@
 import Mousetrap from 'mousetrap';
 import _ from 'underscore';
 import Sidebar from './right_sidebar';
-import ShortcutsNavigation from './shortcuts_navigation';
+import Shortcuts from './shortcuts';
 import { CopyAsGFM } from './behaviors/copy_as_gfm';
 
-export default class ShortcutsIssuable extends ShortcutsNavigation {
+export default class ShortcutsIssuable extends Shortcuts {
   constructor(isMergeRequest) {
     super();
 

From f818518785a76b52afd81b8949146ce872771277 Mon Sep 17 00:00:00 2001
From: Phil Hughes <me@iamphill.com>
Date: Mon, 15 Jan 2018 09:17:00 +0000
Subject: [PATCH 3/5] removed console.log

---
 app/assets/javascripts/dispatcher.js | 1 -
 1 file changed, 1 deletion(-)

diff --git a/app/assets/javascripts/dispatcher.js b/app/assets/javascripts/dispatcher.js
index 1e8d693093f..aa6eeab9827 100644
--- a/app/assets/javascripts/dispatcher.js
+++ b/app/assets/javascripts/dispatcher.js
@@ -302,7 +302,6 @@ import Activities from './activities';
           window.mergeRequest = new MergeRequest({
             action: mrShowNode.dataset.mrAction,
           });
-          console.log('asd');
           shortcut_handler = new ShortcutsIssuable(true);
           break;
         case 'dashboard:activity':

From 8e629a454545a32dd6737cc7ccbd5d2d4bf3fa02 Mon Sep 17 00:00:00 2001
From: Phil Hughes <me@iamphill.com>
Date: Tue, 16 Jan 2018 16:20:59 +0000
Subject: [PATCH 4/5] fixed specs

---
 app/assets/javascripts/dispatcher.js          |   2 +-
 .../javascripts/projects/project_new.js       | 108 ++++++++++++++++++
 spec/javascripts/projects/project_new_spec.js |   4 +-
 3 files changed, 111 insertions(+), 3 deletions(-)
 create mode 100644 app/assets/javascripts/projects/project_new.js

diff --git a/app/assets/javascripts/dispatcher.js b/app/assets/javascripts/dispatcher.js
index aa6eeab9827..b372d038eac 100644
--- a/app/assets/javascripts/dispatcher.js
+++ b/app/assets/javascripts/dispatcher.js
@@ -64,7 +64,7 @@ import Activities from './activities';
         return false;
       }
 
-      const fail = (e) => { throw e; Flash('Error loading dynamic module'); }
+      const fail = () => Flash('Error loading dynamic module');
       const callDefault = m => m.default();
 
       path = page.split(':');
diff --git a/app/assets/javascripts/projects/project_new.js b/app/assets/javascripts/projects/project_new.js
new file mode 100644
index 00000000000..4710e70d619
--- /dev/null
+++ b/app/assets/javascripts/projects/project_new.js
@@ -0,0 +1,108 @@
+let hasUserDefinedProjectPath = false;
+
+const deriveProjectPathFromUrl = ($projectImportUrl) => {
+  const $currentProjectPath = $projectImportUrl.parents('.toggle-import-form').find('#project_path');
+  if (hasUserDefinedProjectPath) {
+    return;
+  }
+
+  let importUrl = $projectImportUrl.val().trim();
+  if (importUrl.length === 0) {
+    return;
+  }
+
+  /*
+    \/?: remove trailing slash
+    (\.git\/?)?: remove trailing .git (with optional trailing slash)
+    (\?.*)?: remove query string
+    (#.*)?: remove fragment identifier
+  */
+  importUrl = importUrl.replace(/\/?(\.git\/?)?(\?.*)?(#.*)?$/, '');
+
+  // extract everything after the last slash
+  const pathMatch = /\/([^/]+)$/.exec(importUrl);
+  if (pathMatch) {
+    $currentProjectPath.val(pathMatch[1]);
+  }
+};
+
+const bindEvents = () => {
+  const $newProjectForm = $('#new_project');
+  const $projectImportUrl = $('#project_import_url');
+  const $projectPath = $('#project_path');
+  const $useTemplateBtn = $('.template-button > input');
+  const $projectFieldsForm = $('.project-fields-form');
+  const $selectedTemplateText = $('.selected-template');
+  const $changeTemplateBtn = $('.change-template');
+  const $selectedIcon = $('.selected-icon svg');
+  const $templateProjectNameInput = $('#template-project-name #project_path');
+
+  if ($newProjectForm.length !== 1) {
+    return;
+  }
+
+  $('.how_to_import_link').on('click', (e) => {
+    e.preventDefault();
+    $(e.currentTarget).next('.modal').show();
+  });
+
+  $('.modal-header .close').on('click', () => {
+    $('.modal').hide();
+  });
+
+  $('.btn_import_gitlab_project').on('click', () => {
+    const importHref = $('a.btn_import_gitlab_project').attr('href');
+    $('.btn_import_gitlab_project').attr('href', `${importHref}?namespace_id=${$('#project_namespace_id').val()}&path=${$projectPath.val()}`);
+  });
+
+  function chooseTemplate() {
+    $('.template-option').hide();
+    $projectFieldsForm.addClass('selected');
+    $selectedIcon.removeClass('active');
+    const value = $(this).val();
+    const templates = {
+      rails: {
+        text: 'Ruby on Rails',
+        icon: '.selected-icon .icon-rails',
+      },
+      express: {
+        text: 'NodeJS Express',
+        icon: '.selected-icon .icon-node-express',
+      },
+      spring: {
+        text: 'Spring',
+        icon: '.selected-icon .icon-java-spring',
+      },
+    };
+
+    const selectedTemplate = templates[value];
+    $selectedTemplateText.text(selectedTemplate.text);
+    $(selectedTemplate.icon).addClass('active');
+    $templateProjectNameInput.focus();
+  }
+
+  $useTemplateBtn.on('change', chooseTemplate);
+
+  $changeTemplateBtn.on('click', () => {
+    $('.template-option').show();
+    $projectFieldsForm.removeClass('selected');
+    $useTemplateBtn.prop('checked', false);
+  });
+
+  $newProjectForm.on('submit', () => {
+    $projectPath.val($projectPath.val().trim());
+  });
+
+  $projectPath.on('keyup', () => {
+    hasUserDefinedProjectPath = $projectPath.val().trim().length > 0;
+  });
+
+  $projectImportUrl.keyup(() => deriveProjectPathFromUrl($projectImportUrl));
+};
+
+document.addEventListener('DOMContentLoaded', bindEvents);
+
+export default {
+  bindEvents,
+  deriveProjectPathFromUrl,
+};
diff --git a/spec/javascripts/projects/project_new_spec.js b/spec/javascripts/projects/project_new_spec.js
index a95fe83e60e..2dd28f873f6 100644
--- a/spec/javascripts/projects/project_new_spec.js
+++ b/spec/javascripts/projects/project_new_spec.js
@@ -1,6 +1,6 @@
-import projectNew from '~/pages/projects/shared/project_new';
+import projectNew from '~/projects/project_new';
 
-describe('New Project', () => {
+fdescribe('New Project', () => {
   let $projectImportUrl;
   let $projectPath;
 

From c3f26b0aaff62db797dda69a43e9dc2a52f70e2f Mon Sep 17 00:00:00 2001
From: Phil Hughes <me@iamphill.com>
Date: Wed, 17 Jan 2018 10:32:33 +0000
Subject: [PATCH 5/5] added project_new import

---
 app/assets/javascripts/pages/projects/new/index.js | 2 ++
 app/assets/javascripts/projects/project_new.js     | 2 --
 spec/javascripts/projects/project_new_spec.js      | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/app/assets/javascripts/pages/projects/new/index.js b/app/assets/javascripts/pages/projects/new/index.js
index 45951461779..71c49deb9d0 100644
--- a/app/assets/javascripts/pages/projects/new/index.js
+++ b/app/assets/javascripts/pages/projects/new/index.js
@@ -1,7 +1,9 @@
 import ProjectNew from '../shared/project_new';
 import initProjectVisibilitySelector from '../../../project_visibility';
+import initProjectNew from '../../../projects/project_new';
 
 export default () => {
   new ProjectNew(); // eslint-disable-line no-new
   initProjectVisibilitySelector();
+  initProjectNew.bindEvents();
 };
diff --git a/app/assets/javascripts/projects/project_new.js b/app/assets/javascripts/projects/project_new.js
index 4710e70d619..f5133111d04 100644
--- a/app/assets/javascripts/projects/project_new.js
+++ b/app/assets/javascripts/projects/project_new.js
@@ -100,8 +100,6 @@ const bindEvents = () => {
   $projectImportUrl.keyup(() => deriveProjectPathFromUrl($projectImportUrl));
 };
 
-document.addEventListener('DOMContentLoaded', bindEvents);
-
 export default {
   bindEvents,
   deriveProjectPathFromUrl,
diff --git a/spec/javascripts/projects/project_new_spec.js b/spec/javascripts/projects/project_new_spec.js
index 2dd28f873f6..c314ca8ab72 100644
--- a/spec/javascripts/projects/project_new_spec.js
+++ b/spec/javascripts/projects/project_new_spec.js
@@ -1,6 +1,6 @@
 import projectNew from '~/projects/project_new';
 
-fdescribe('New Project', () => {
+describe('New Project', () => {
   let $projectImportUrl;
   let $projectPath;