From 86016960811e90ceecdd0353753107943cdea1d8 Mon Sep 17 00:00:00 2001 From: Pier Paolo Ramon Date: Fri, 2 Dec 2016 13:28:35 +0000 Subject: [PATCH 1/4] Minor white-space source formatting --- app/assets/stylesheets/pages/boards.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/assets/stylesheets/pages/boards.scss b/app/assets/stylesheets/pages/boards.scss index 82f36f24867..c55cecd57c8 100644 --- a/app/assets/stylesheets/pages/boards.scss +++ b/app/assets/stylesheets/pages/boards.scss @@ -31,7 +31,7 @@ .dropdown-content { max-height: 150px; - } + } } .issue-board-dropdown-content { From e19d4ce269b77f48a00547971ad3796affea9005 Mon Sep 17 00:00:00 2001 From: Pier Paolo Ramon Date: Fri, 2 Dec 2016 13:33:39 +0000 Subject: [PATCH 2/4] Extend the list header top border to the edge of the box With border board lists (those created from labels) the top border created bad visual artifacts with the .board-inner gray border. With this change the colored border overflows the padding-box of .board-inner and extends to the edges. It works very well with most colors, excepts for very light ones (such as `#ff0` yellow for instance). --- app/assets/stylesheets/pages/boards.scss | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/app/assets/stylesheets/pages/boards.scss b/app/assets/stylesheets/pages/boards.scss index c55cecd57c8..bff84b36eec 100644 --- a/app/assets/stylesheets/pages/boards.scss +++ b/app/assets/stylesheets/pages/boards.scss @@ -109,6 +109,12 @@ &.has-border { border-top: 3px solid; + margin-top: -1px; + margin-right: -1px; + margin-left: -1px; + padding-top: 1px; + padding-right: 1px; + padding-left: 1px; .board-title { padding-top: ($gl-padding - 3px); From 23f1f7f49fd404a7617f7e8ab5754c19099a3725 Mon Sep 17 00:00:00 2001 From: Pier Paolo Ramon Date: Fri, 2 Dec 2016 19:44:20 +0000 Subject: [PATCH 3/4] Add Changelog entry for !7898 --- ...xes-issue-boards-list-colored-top-border-visual-glitch.yml | 4 ++++ 1 file changed, 4 insertions(+) create mode 100644 changelogs/unreleased/7898-fixes-issue-boards-list-colored-top-border-visual-glitch.yml diff --git a/changelogs/unreleased/7898-fixes-issue-boards-list-colored-top-border-visual-glitch.yml b/changelogs/unreleased/7898-fixes-issue-boards-list-colored-top-border-visual-glitch.yml new file mode 100644 index 00000000000..e763194baf9 --- /dev/null +++ b/changelogs/unreleased/7898-fixes-issue-boards-list-colored-top-border-visual-glitch.yml @@ -0,0 +1,4 @@ +--- +title: Fixes issue boards list colored top border visual glitch +merge_request: 7898 +author: Pier Paolo Ramon \ No newline at end of file From bb1fd0566fc00a9c699a23dceb1e5f0aa7e9dbbe Mon Sep 17 00:00:00 2001 From: Pier Paolo Ramon Date: Sat, 3 Dec 2016 11:39:36 +0000 Subject: [PATCH 4/4] Fix Changelog entry for !7898 --- ...fixes-issue-boards-list-colored-top-border-visual-glitch.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/changelogs/unreleased/7898-fixes-issue-boards-list-colored-top-border-visual-glitch.yml b/changelogs/unreleased/7898-fixes-issue-boards-list-colored-top-border-visual-glitch.yml index e763194baf9..74412c32375 100644 --- a/changelogs/unreleased/7898-fixes-issue-boards-list-colored-top-border-visual-glitch.yml +++ b/changelogs/unreleased/7898-fixes-issue-boards-list-colored-top-border-visual-glitch.yml @@ -1,4 +1,4 @@ --- title: Fixes issue boards list colored top border visual glitch merge_request: 7898 -author: Pier Paolo Ramon \ No newline at end of file +author: Pier Paolo Ramon