kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Unify pipeline_for(ref, nil) and pipeline_for(ref), feedback:

Browse source 
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5142#note_14073464
This commit is contained in:
Lin Jen-Shin 2016-08-19 17:42:49 +08:00
parent 9c9259cc6a
commit 1aba3a5c0e
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
app/models/project.rb
View file

@ -1094,8 +1094,11 @@ class Project < ActiveRecord::Base
!namespace.share_with_group_lock
end
def pipeline_for(ref, sha = commit(ref).try(:sha))
def pipeline_for(ref, sha = nil)
sha ||= commit(ref).try(:sha)
return unless sha
pipelines.order(id: :desc).find_by(sha: sha, ref: ref)
end