kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Add spec for CompareService

Browse source 
The return result for the source or target branch being missing was
ambiguous before. It should be an empty compare to indicate no
comparison could be done.
This commit is contained in:
Stan Hu 2019-04-14 15:56:02 -07:00 committed by Oswaldo Ferreira
parent 5d74c95c98
commit 1ac4b24dd3
1 changed files with 13 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
spec/services/compare_service_spec.rb
View file

@ -19,5 +19,18 @@ describe CompareService do
it { expect(subject.diffs.size).to eq(3) } it { expect(subject.diffs.size).to eq(3) }
end end
context 'compare with target branch that does not exist' do
subject { service.execute(project, 'non-existent-ref') }
it { expect(subject).to be_nil }
end
context 'compare with source branch that does not exist' do
let(:service) { described_class.new(project, 'non-existent-branch') }
subject { service.execute(project, 'non-existent-ref') }
it { expect(subject).to be_nil }
end
end end
end end