From 1b2de25deeab172cabd8d74ad7fc60a4db39cbe5 Mon Sep 17 00:00:00 2001 From: Sean McGivern Date: Thu, 6 Jun 2019 19:14:08 +0100 Subject: [PATCH] Don't fail the pipeline when a colon-emoji is used A colon-emoji like :100: can be valid in the case where we're talking about the GitLab feature that processes these into emojis. It's fine to warn about those, but failing the pipeline is too restrictive. --- danger/commit_messages/Dangerfile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/danger/commit_messages/Dangerfile b/danger/commit_messages/Dangerfile index 048c539bcf9..bdb4343b1d6 100644 --- a/danger/commit_messages/Dangerfile +++ b/danger/commit_messages/Dangerfile @@ -163,10 +163,10 @@ def lint_commit(commit) end if emoji_checker.includes_emoji?(commit.message) - fail_commit( + warn_commit( commit, 'Avoid the use of Markdown Emoji such as `:+1:`. ' \ - 'These add no value to the commit message, ' \ + 'These add limited value to the commit message, ' \ 'and are displayed as plain text outside of GitLab' )