kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Fixed bug with merge immediately button would not work

Browse source 
This was caused by using 'this' in a fat arrow function, so 'this' would not equal the jQuery element
This commit is contained in:
Phil Hughes 2017-01-22 11:39:51 +00:00
parent 125abfd4b2
commit 1b3b4f4e34
2 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/assets/javascripts/merge_request_widget/ci_bundle.js.es6
View file

@ -30,7 +30,7 @@
.off('click', '.js-merge-dropdown a')
.on('click', '.js-merge-dropdown a', (e) => {
e.preventDefault();
$(this).closest('form').submit();
$(e.target).closest('form').submit();
});
if ($('.rebase-in-progress').length) {
merge_request_widget.rebaseInProgress();

4
changelogs/unreleased/merge-dropdown-this-context.yml Normal file
View file

@ -0,0 +1,4 @@
---
title: Fixed bug where links in merge dropdown wouldn't work
merge_request:
author: