From 1b8a576d3fe9d283ad20ebb863bd11ec58eb5fb5 Mon Sep 17 00:00:00 2001 From: "http://jneen.net/" Date: Tue, 13 Dec 2016 12:15:42 -0800 Subject: [PATCH] Be more certain in the comment --- lib/gitlab/email/reply_parser.rb | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/gitlab/email/reply_parser.rb b/lib/gitlab/email/reply_parser.rb index 971afe4a878..7dedd5ec4aa 100644 --- a/lib/gitlab/email/reply_parser.rb +++ b/lib/gitlab/email/reply_parser.rb @@ -18,8 +18,9 @@ module Gitlab # not using /\s+$/ here because that deletes empty lines body = body.gsub(/[ \t]$/, '') - # TODO [jneen]: do we want to allow empty-quoting? (replies only containing a blockquote) - # EmailReplyTrimmer allows this as a special case, so we detect it manually here. + # NOTE: We currently don't support empty quotes. + # EmailReplyTrimmer allows this as a special case, + # so we detect it manually here. return "" if body.lines.all? { |l| l.strip.empty? || l.start_with?('>') } body.force_encoding(encoding).encode("UTF-8")