Stub Rails.application.env_config to prevent spec failures
When we modify env_config, that is on the global Rails.application, and we need to stub it and allow it to be modified in-place, without polluting later tests. When we modify env, then the context is a request, or something else that only lives for a single spec. Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/8488
This commit is contained in:
parent
e2aa2177a7
commit
1bac28d0a9
|
@ -8,8 +8,15 @@ module DeviseHelpers
|
||||||
end
|
end
|
||||||
|
|
||||||
def env_from_context(context)
|
def env_from_context(context)
|
||||||
|
# When we modify env_config, that is on the global
|
||||||
|
# Rails.application, and we need to stub it and allow it to be
|
||||||
|
# modified in-place, without polluting later tests.
|
||||||
if context.respond_to?(:env_config)
|
if context.respond_to?(:env_config)
|
||||||
context.env_config
|
context.env_config.deep_dup.tap do |env|
|
||||||
|
allow(context).to receive(:env_config).and_return(env)
|
||||||
|
end
|
||||||
|
# When we modify env, then the context is a request, or something
|
||||||
|
# else that only lives for a single spec.
|
||||||
elsif context.respond_to?(:env)
|
elsif context.respond_to?(:env)
|
||||||
context.env
|
context.env
|
||||||
end
|
end
|
||||||
|
|
Loading…
Reference in New Issue