Apply additional guard-clauses for unfold_required?

2018-11-06 17:59:09 -02:00 · 2018-11-06 17:59:09 -02:00 · 1bc0e9e3c5
parent ec66ef1b74
commit 1bc0e9e3c5
1 changed files with 2 additions and 1 deletions
--- a/lib/gitlab/diff/lines_unfolder.rb
+++ b/lib/gitlab/diff/lines_unfolder.rb
@ -54,7 +54,8 @@ module Gitlab
      def unfold_required?
        strong_memoize(:unfold_required) do
          next false unless @diff_file.text?
-          next false if @blob.nil?
+          next false unless @position.unchanged?
+          next false if @diff_file.new_file? || @diff_file.deleted_file?
          next false unless @position.old_line
          # Invalid position (MR import scenario)
          next false if @position.old_line > @blob.lines.size