Refactor attribute_cleaner for readability

This commit is contained in:
charlieablett 2019-04-30 11:25:09 +12:00
parent b240012c4f
commit 1cbdc5326c

View file

@ -18,13 +18,15 @@ module Gitlab
def clean def clean
@relation_hash.reject do |key, _value| @relation_hash.reject do |key, _value|
(prohibited_key?(key) && !permitted_key?(key)) || !@relation_class.attribute_method?(key) || excluded_key?(key) prohibited_key?(key) || !@relation_class.attribute_method?(key) || excluded_key?(key)
end.except('id') end.except('id')
end end
private private
def prohibited_key?(key) def prohibited_key?(key)
return false if permitted_key?(key)
'cached_markdown_version' == key || PROHIBITED_SUFFIXES.any? {|suffix| key.end_with?(suffix)} 'cached_markdown_version' == key || PROHIBITED_SUFFIXES.any? {|suffix| key.end_with?(suffix)}
end end