DRY exception handling
Use `retry_on_exception` instead of duplicating code
This commit is contained in:
parent
20bb0d66f2
commit
1dbc25e886
|
@ -10,18 +10,11 @@ module QA
|
|||
end
|
||||
|
||||
def perform_before_hooks
|
||||
retries ||= 0
|
||||
|
||||
# The login page could take some time to load the first time it is visited.
|
||||
# We visit the login page and wait for it to properly load only once before the tests.
|
||||
QA::Runtime::Browser.visit(:gitlab, QA::Page::Main::Login)
|
||||
rescue QA::Page::Validatable::PageValidationError
|
||||
if (retries += 1) < 3
|
||||
Runtime::Logger.warn("The login page did not appear as expected. Retrying... (attempt ##{retries})")
|
||||
retry
|
||||
QA::Support::Retrier.retry_on_exception do
|
||||
QA::Runtime::Browser.visit(:gitlab, QA::Page::Main::Login)
|
||||
end
|
||||
|
||||
raise
|
||||
end
|
||||
end
|
||||
end
|
||||
|
|
Loading…
Reference in New Issue