kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

remove obsolete favicon related spec

Browse source 
the favicon variations don't need to be tested on the entity anymore, as
they are A) tested in the dedicated `Gitlab::Favicon` and B) they are
created on the client (i.e. the overlays are always the same for all
base favicon variants).
This commit is contained in:
Alexis Reigel 2018-04-14 15:37:32 +02:00 committed by Alexis Reigel
parent 7706b3a471
commit 1e9c33acd1
No known key found for this signature in database
GPG key ID: C728AF10972E97C0
1 changed files with 0 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
spec/serializers/status_entity_spec.rb
View file

@ -20,15 +20,5 @@ describe StatusEntity do
expect(subject).to include :has_details, :details_path expect(subject).to include :has_details, :details_path
expect(subject[:favicon]).to match_asset_path('/assets/ci_favicons/favicon_status_success.png') expect(subject[:favicon]).to match_asset_path('/assets/ci_favicons/favicon_status_success.png')
end end
it 'contains a dev namespaced favicon if dev env' do
allow(Rails.env).to receive(:development?) { true }
expect(entity.as_json[:favicon]).to match_asset_path('/assets/ci_favicons/favicon_status_success.png')
end
it 'contains a canary namespaced favicon if canary env' do
stub_env('CANARY', 'true')
expect(entity.as_json[:favicon]).to match_asset_path('/assets/ci_favicons/canary/favicon_status_success.png')
end
end end
end end