quick action label must be first in issue comment

This commit is contained in:
Maneschi Romain 2019-09-02 10:42:11 +00:00 committed by Nick Thomas
parent 146e12a07e
commit 1eca1928eb
3 changed files with 23 additions and 1 deletions

View File

@ -5,8 +5,8 @@ module QuickActions
include Gitlab::Utils::StrongMemoize
include Gitlab::QuickActions::Dsl
include Gitlab::QuickActions::IssueActions
include Gitlab::QuickActions::IssueAndMergeRequestActions
include Gitlab::QuickActions::IssuableActions
include Gitlab::QuickActions::IssueAndMergeRequestActions
include Gitlab::QuickActions::MergeRequestActions
include Gitlab::QuickActions::CommitActions
include Gitlab::QuickActions::CommonActions

View File

@ -0,0 +1,5 @@
---
title: Quick action label must be first in issue comment
merge_request: 32367
author: Romain Maneschi
type: fixed

View File

@ -55,6 +55,23 @@ describe "User comments on issue", :js do
expect(page.find('svg.mermaid')).to have_content escaped_content
end
it 'opens autocomplete menu for quick actions and have `/label` first choice' do
project.add_maintainer(user)
create(:label, project: project, title: 'label')
page.within '.timeline-content-form' do
find('#note-body').native.send_keys('/l')
end
wait_for_requests
expect(page).to have_selector('.atwho-container')
page.within '.atwho-container #at-view-commands' do
expect(find('li', match: :first)).to have_content('/label')
end
end
end
context "when editing comments" do