kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Remove PersonalSnippet case for reportable_note specs

Browse source
This commit is contained in:
Luke "Jared" Bennett 2017-06-20 09:03:04 +01:00
parent f50a806531
commit 1f9fb9e457
No known key found for this signature in database
GPG key ID: 402ED51FB5D306C2
2 changed files with 7 additions and 39 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
spec/features/reportable_note/snippets_spec.rb
View file

@ -19,16 +19,4 @@ describe 'Reportable note on snippets', :feature, :js do
it_behaves_like 'reportable note'
end
describe 'on personal snippet' do
let(:snippet) { create(:personal_snippet, :public, author: user) }
let!(:note) { create(:note_on_personal_snippet, noteable: snippet) }
let!(:owners_note) { create(:note_on_personal_snippet, noteable: snippet, author: user) }
before do
visit snippet_path(snippet)
end
it_behaves_like 'reportable note', true
end
end

34
spec/support/features/reportable_note_shared_examples.rb
View file

@ -1,6 +1,6 @@
require 'spec_helper'
shared_examples 'reportable note' do |is_a_personal_snippet|
shared_examples 'reportable note' do
include NotesHelper
let(:comment) { find("##{ActionView::RecordIdentifier.dom_id(note)}") }
@ -11,33 +11,13 @@ shared_examples 'reportable note' do |is_a_personal_snippet|
expect(comment).to have_selector(more_actions_selector)
end
if is_a_personal_snippet
it 'dropdown has Report link on other users comment' do
dropdown = comment.find(more_actions_selector)
open_dropdown(dropdown)
it 'dropdown has Edit, Report and Delete links' do
dropdown = comment.find(more_actions_selector)
open_dropdown(dropdown)
expect(dropdown).to have_link('Report as abuse', href: abuse_report_path)
end
it 'dropdown has Edit and Delete links on the owners comment' do
find('#notes-list .note', match: :first)
other_comment = all('#notes-list .note').last
dropdown = other_comment.find(more_actions_selector)
open_dropdown(dropdown)
expect(dropdown).to have_button('Edit comment')
expect(dropdown).to have_link('Delete comment', href: note_url(owners_note, project))
end
else
it 'dropdown has Edit, Report and Delete links' do
dropdown = comment.find(more_actions_selector)
open_dropdown(dropdown)
expect(dropdown).to have_button('Edit comment')
expect(dropdown).to have_link('Report as abuse', href: abuse_report_path)
expect(dropdown).to have_link('Delete comment', href: note_url(note, project))
end
expect(dropdown).to have_button('Edit comment')
expect(dropdown).to have_link('Report as abuse', href: abuse_report_path)
expect(dropdown).to have_link('Delete comment', href: note_url(note, project))
end
it 'Report button links to a report page' do