Update according to review comments
This commit is contained in:
parent
6b124d42d9
commit
21041525af
2 changed files with 5 additions and 6 deletions
|
@ -19,7 +19,7 @@ v 8.7.0 (unreleased)
|
||||||
- Fix `signed_in_ip` being set to 127.0.0.1 when using a reverse proxy !3524
|
- Fix `signed_in_ip` being set to 127.0.0.1 when using a reverse proxy !3524
|
||||||
- Improved Markdown rendering performance !3389
|
- Improved Markdown rendering performance !3389
|
||||||
- Improved Markdown rendering performance !3389 (Yorick Peterse)
|
- Improved Markdown rendering performance !3389 (Yorick Peterse)
|
||||||
- Make shared runners text in box configurable (Kamil Trzciński)
|
- Make shared runners text in box configurable
|
||||||
- Don't attempt to look up an avatar in repo if repo directory does not exist (Stan Hu)
|
- Don't attempt to look up an avatar in repo if repo directory does not exist (Stan Hu)
|
||||||
- API: Ability to subscribe and unsubscribe from issues and merge requests (Robert Schilling)
|
- API: Ability to subscribe and unsubscribe from issues and merge requests (Robert Schilling)
|
||||||
- Expose project badges in project settings
|
- Expose project badges in project settings
|
||||||
|
|
|
@ -83,12 +83,11 @@ describe "Runners" do
|
||||||
describe "shared runners description" do
|
describe "shared runners description" do
|
||||||
let(:shared_runners_text) { 'custom shared runners description' }
|
let(:shared_runners_text) { 'custom shared runners description' }
|
||||||
|
|
||||||
before { stub_application_setting(shared_runners_text: shared_runners_text) }
|
|
||||||
|
|
||||||
before do
|
before do
|
||||||
@project = FactoryGirl.create :empty_project, shared_runners_enabled: false
|
stub_application_setting(shared_runners_text: shared_runners_text)
|
||||||
@project.team << [user, :master]
|
project = FactoryGirl.create :empty_project, shared_runners_enabled: false
|
||||||
visit runners_path(@project)
|
project.team << [user, :master]
|
||||||
|
visit runners_path(project)
|
||||||
end
|
end
|
||||||
|
|
||||||
it "sees shared runners description" do
|
it "sees shared runners description" do
|
||||||
|
|
Loading…
Reference in a new issue