kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Use Commit#short_id instead of Commit.truncate_sha

Browse source
This commit is contained in:
Douglas Barbosa Alexandre 2016-03-18 10:32:22 -03:00
parent 2eeeb266e3
commit 231d4fb9f8
2 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/models/todo.rb
View file

@ -73,7 +73,7 @@ class Todo < ActiveRecord::Base
def to_reference
if for_commit?
Commit.truncate_sha(commit_id)
target.short_id
else
target.to_reference
end

4
spec/models/todo_spec.rb
View file

@ -117,9 +117,11 @@ describe Todo, models: true do
describe '#to_reference' do
it 'returns the short commit id for commits' do
subject.project = project
subject.target_type = 'Commit'
subject.commit_id = commit.id
expect(subject.to_reference).to eq Commit.truncate_sha(commit.id)
expect(subject.to_reference).to eq commit.short_id
end
it 'returns reference for issuables' do