Remove unnecessary ORDER BY clause when updating todos

This commit is contained in:
mhasbini 2017-04-02 20:48:58 +03:00
parent 9fc17f6f4a
commit 2332bf34ac
2 changed files with 5 additions and 1 deletions

View File

@ -204,7 +204,7 @@ class TodoService
# Only update those that are not really on that state
todos = todos.where.not(state: state)
todos_ids = todos.pluck(:id)
todos.update_all(state: state)
todos.unscope(:order).update_all(state: state)
current_user.update_todos_count_cache
todos_ids
end

View File

@ -0,0 +1,4 @@
---
title: Remove unnecessary ORDER BY clause when updating todos
merge_request:
author: mhasbini