From 237ead18b945830ed60ac1b4382a4431d66818a6 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Thu, 10 Mar 2022 00:08:36 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .../error_tracking/components/constants.js | 21 -- .../components/error_details.vue | 2 +- .../components/error_tracking_list.vue | 44 +++ .../javascripts/error_tracking/constants.js | 30 ++ app/assets/javascripts/error_tracking/list.js | 8 +- .../components/app.vue | 64 +++- .../error_tracking_settings/constants.js | 7 + .../concerns/membership_actions.rb | 11 - .../groups/group_members_controller.rb | 2 +- .../projects/error_tracking_controller.rb | 4 + .../settings/operations_controller.rb | 4 + app/helpers/projects/error_tracking_helper.rb | 14 +- .../project_error_tracking_setting.rb | 4 + app/models/integration.rb | 8 - app/models/integrations/jira.rb | 4 - app/models/integrations/zentao.rb | 4 - .../development/integrated_error_tracking.yml | 8 + config/routes/group.rb | 2 +- config/routes/project.rb | 2 +- ...5223212_add_security_training_providers.rb | 40 +++ db/schema_migrations/20220305223212 | 1 + doc/api/graphql/reference/index.md | 4 + doc/development/contributing/style_guides.md | 25 +- doc/development/rake_tasks.md | 10 + doc/operations/error_tracking.md | 12 +- .../vulnerabilities/index.md | 13 +- lib/api/entities/error_tracking.rb | 6 + lib/api/error_tracking/collector.rb | 4 +- lib/gitlab/health_checks/db_check.rb | 6 +- lib/tasks/rubocop.rake | 52 +++- locale/gitlab.pot | 9 + qa/qa/page/trials/new.rb | 2 +- qa/qa/page/trials/select.rb | 11 +- qa/qa/resource/fork.rb | 2 +- qa/qa/resource/runner.rb | 5 +- .../api/4_verify/remove_runner_spec.rb | 36 +++ rubocop/formatter/todo_formatter.rb | 138 +++++++++ rubocop/todo_dir.rb | 81 +++++ .../groups/group_members_controller_spec.rb | 109 ------- .../project_members_controller_spec.rb | 173 ----------- .../components/error_details_spec.js | 6 +- .../components/error_tracking_list_spec.js | 63 +++- .../components/app_spec.js | 155 ++++++---- .../projects/error_tracking_helper_spec.rb | 34 ++- .../lib/gitlab/health_checks/db_check_spec.rb | 17 +- ...12_add_security_training_providers_spec.rb | 25 ++ .../project_error_tracking_setting_spec.rb | 19 ++ .../api/error_tracking/collector_spec.rb | 9 +- .../error_tracking/project_settings_spec.rb | 59 +++- spec/requests/api/invitations_spec.rb | 19 ++ spec/routing/project_routing_spec.rb | 2 +- spec/rubocop/formatter/todo_formatter_spec.rb | 284 ++++++++++++++++++ spec/rubocop/todo_dir_spec.rb | 218 ++++++++++++++ spec/spec_helper.rb | 9 - spec/support/silence_stdout.rb | 12 + spec/tasks/rubocop_rake_spec.rb | 168 +++++++++++ 56 files changed, 1609 insertions(+), 472 deletions(-) delete mode 100644 app/assets/javascripts/error_tracking/components/constants.js create mode 100644 app/assets/javascripts/error_tracking/constants.js create mode 100644 app/assets/javascripts/error_tracking_settings/constants.js create mode 100644 config/feature_flags/development/integrated_error_tracking.yml create mode 100644 db/post_migrate/20220305223212_add_security_training_providers.rb create mode 100644 db/schema_migrations/20220305223212 create mode 100644 qa/qa/specs/features/api/4_verify/remove_runner_spec.rb create mode 100644 rubocop/formatter/todo_formatter.rb create mode 100644 rubocop/todo_dir.rb create mode 100644 spec/migrations/20220305223212_add_security_training_providers_spec.rb create mode 100644 spec/rubocop/formatter/todo_formatter_spec.rb create mode 100644 spec/rubocop/todo_dir_spec.rb create mode 100644 spec/support/silence_stdout.rb create mode 100644 spec/tasks/rubocop_rake_spec.rb diff --git a/app/assets/javascripts/error_tracking/components/constants.js b/app/assets/javascripts/error_tracking/components/constants.js deleted file mode 100644 index 41b952e26d8..00000000000 --- a/app/assets/javascripts/error_tracking/components/constants.js +++ /dev/null @@ -1,21 +0,0 @@ -export const severityLevel = { - FATAL: 'fatal', - ERROR: 'error', - WARNING: 'warning', - INFO: 'info', - DEBUG: 'debug', -}; - -export const severityLevelVariant = { - [severityLevel.FATAL]: 'danger', - [severityLevel.ERROR]: 'neutral', - [severityLevel.WARNING]: 'warning', - [severityLevel.INFO]: 'info', - [severityLevel.DEBUG]: 'muted', -}; - -export const errorStatus = { - IGNORED: 'ignored', - RESOLVED: 'resolved', - UNRESOLVED: 'unresolved', -}; diff --git a/app/assets/javascripts/error_tracking/components/error_details.vue b/app/assets/javascripts/error_tracking/components/error_details.vue index e00fec6fddf..0a8abdc90c6 100644 --- a/app/assets/javascripts/error_tracking/components/error_details.vue +++ b/app/assets/javascripts/error_tracking/components/error_details.vue @@ -26,7 +26,7 @@ import { trackErrorStatusUpdateOptions, } from '../utils'; -import { severityLevel, severityLevelVariant, errorStatus } from './constants'; +import { severityLevel, severityLevelVariant, errorStatus } from '../constants'; import Stacktrace from './stacktrace.vue'; const SENTRY_TIMEOUT = 10000; diff --git a/app/assets/javascripts/error_tracking/components/error_tracking_list.vue b/app/assets/javascripts/error_tracking/components/error_tracking_list.vue index 5db8c8cf8d3..3d540d46b3c 100644 --- a/app/assets/javascripts/error_tracking/components/error_tracking_list.vue +++ b/app/assets/javascripts/error_tracking/components/error_tracking_list.vue @@ -1,5 +1,6 @@