From 2592aec9e3a7a1b0d2689dd14cc6e0b9cea068cd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Matija=20=C4=8Cupi=C4=87?= Date: Tue, 23 Jan 2018 19:53:29 +0100 Subject: [PATCH] Use all parameters in VariablesController specs --- .../groups/variables_controller_spec.rb | 18 +++++++++++++----- .../projects/variables_controller_spec.rb | 18 +++++++++++++----- 2 files changed, 26 insertions(+), 10 deletions(-) diff --git a/spec/controllers/groups/variables_controller_spec.rb b/spec/controllers/groups/variables_controller_spec.rb index 8570df15f34..4299c3b0040 100644 --- a/spec/controllers/groups/variables_controller_spec.rb +++ b/spec/controllers/groups/variables_controller_spec.rb @@ -16,8 +16,11 @@ describe Groups::VariablesController do subject do post :save_multiple, group_id: group, - variables_attributes: [{ id: variable.id, key: variable.key, value: 'other_value' }, - { key: '..?', value: 'dummy_value' }], + variables_attributes: [{ id: variable.id, key: variable.key, + value: 'other_value', + protected: variable.protected?.to_s }, + { key: '..?', value: 'dummy_value', + protected: 'false' }], format: :json end @@ -40,8 +43,11 @@ describe Groups::VariablesController do subject do post :save_multiple, group_id: group, - variables_attributes: [{ id: variable.id, key: variable.key, value: 'other_value' }, - { key: 'new_key', value: 'dummy_value' }], + variables_attributes: [{ id: variable.id, key: variable.key, + value: 'other_value', + protected: variable.protected?.to_s }, + { key: 'new_key', value: 'dummy_value', + protected: 'false' }], format: :json end @@ -65,7 +71,9 @@ describe Groups::VariablesController do post :save_multiple, group_id: group, variables_attributes: [{ id: variable.id, key: variable.key, - value: variable.value, _destroy: 'true' }], + value: variable.value, + protected: variable.protected?.to_s, + _destroy: 'true' }], format: :json end diff --git a/spec/controllers/projects/variables_controller_spec.rb b/spec/controllers/projects/variables_controller_spec.rb index 4cbc2fb443a..ac5c453a8ab 100644 --- a/spec/controllers/projects/variables_controller_spec.rb +++ b/spec/controllers/projects/variables_controller_spec.rb @@ -20,8 +20,11 @@ describe Projects::VariablesController do subject do post :save_multiple, namespace_id: project.namespace.to_param, project_id: project, - variables_attributes: [{ id: variable.id, key: variable.key, value: 'other_value' }, - { key: '..?', value: 'dummy_value' }], + variables_attributes: [{ id: variable.id, key: variable.key, + value: 'other_value', + protected: variable.protected?.to_s }, + { key: '..?', value: 'dummy_value', + protected: 'false' }], format: :json end @@ -44,8 +47,11 @@ describe Projects::VariablesController do subject do post :save_multiple, namespace_id: project.namespace.to_param, project_id: project, - variables_attributes: [{ id: variable.id, key: variable.key, value: 'other_value' }, - { key: 'new_key', value: 'dummy_value' }], + variables_attributes: [{ id: variable.id, key: variable.key, + value: 'other_value', + protected: variable.protected?.to_s }, + { key: 'new_key', value: 'dummy_value', + protected: 'false' }], format: :json end @@ -69,7 +75,9 @@ describe Projects::VariablesController do post :save_multiple, namespace_id: project.namespace.to_param, project_id: project, variables_attributes: [{ id: variable.id, key: variable.key, - value: variable.value, _destroy: 'true' }], + value: variable.value, + protected: variable.protected?.to_s, + _destroy: 'true' }], format: :json end