From 25db9c1230f7b54a7337b3d2dfe714478a7d54f0 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Thu, 6 May 2021 12:10:38 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .../issue_templates/Feature Flag Roll Out.md | 3 + .rubocop_manual_todo.yml | 4 +- GITALY_SERVER_VERSION | 2 +- Gemfile | 2 +- Gemfile.lock | 4 +- .../images/dev_ops_report_no_data.svg} | 0 .../devops_report/components/devops_score.vue | 27 +++- .../analytics/devops_report/devops_score.js | 4 +- ...js => devops_score_disabled_usage_ping.js} | 2 +- .../pages/admin/dev_ops_report/index.js | 4 +- .../pages/groups/milestones/edit/index.js | 2 +- .../pages/groups/milestones/new/index.js | 2 +- .../{ => show}/index.js | 0 .../{index => show}/index.js | 0 .../states/unresolved_discussions.vue | 2 +- .../page_bundles/_pipeline_mixins.scss | 2 +- .../page_bundles/dev_ops_report.scss | 6 - .../groups/autocomplete_sources_controller.rb | 54 +++++++ .../groups/milestones_controller.rb | 4 +- .../packages_and_registries_controller.rb | 2 +- .../projects/milestones_controller.rb | 4 +- .../packages_and_registries_controller.rb | 2 +- app/graphql/types/ci/pipeline_type.rb | 16 +- app/graphql/types/ci/stage_type.rb | 55 ++----- app/graphql/types/group_type.rb | 2 +- app/graphql/types/project_type.rb | 13 +- app/graphql/types/timelog_type.rb | 5 + app/helpers/application_helper.rb | 29 ++-- app/helpers/dev_ops_report_helper.rb | 2 + app/helpers/groups_helper.rb | 2 +- app/helpers/invite_members_helper.rb | 4 + app/helpers/projects_helper.rb | 2 +- app/models/concerns/has_timelogs_report.rb | 2 +- app/models/timelog.rb | 8 +- app/policies/ci/stage_policy.rb | 7 + .../code_quality_mr_diff_presenter.rb | 10 +- .../group_issuable_autocomplete_entity.rb | 9 ++ .../group_issuable_autocomplete_serializer.rb | 5 + ...rate_codequality_mr_diff_report_service.rb | 2 +- ...ate_code_quality_mr_diff_report_service.rb | 59 ++++++- app/services/groups/autocomplete_service.rb | 49 ++++++ app/services/groups/participants_service.rb | 31 ++++ .../admin/dev_ops_report/_no_data.html.haml | 7 - .../admin/dev_ops_report/_report.html.haml | 6 +- app/views/groups/milestones/_form.html.haml | 6 +- .../{index.html.haml => show.html.haml} | 0 .../nav/sidebar/_project_menus.html.haml | 31 ---- app/views/projects/milestones/_form.html.haml | 6 +- .../projects/project_members/index.html.haml | 19 ++- .../{index.html.haml => show.html.haml} | 0 .../create_quality_report_worker.rb | 2 +- ...convert-score-page-to-vue-components-2.yml | 5 + ...hover-focus-states-on-pipeline-buttons.yml | 5 + ...-authorization-to-pipeline-fields-that.yml | 5 + ...verse-index-on-namespaces-parent_id-id.yml | 5 + .../expose-mr-timelogs-via-graphql.yml | 5 + ...at-milestone-description-auto-complete.yml | 5 + ...enshift-template-to-run-on-main-branch.yml | 5 + .../mo-fix-codequality-mr-diff-report.yml | 5 + ...k_ecosystem_slack_service-feature-flag.yml | 5 + ...vice.yml => cached_encoding_detection.yml} | 10 +- .../find_remote_root_refs_inmemory.yml | 8 + .../development/limited_diff_highlighting.yml | 8 + ...roups.yml => track_highlight_timeouts.yml} | 10 +- config/routes/group.rb | 13 +- config/routes/project.rb | 2 +- ...aces_id_parent_id_inverse_partial_index.rb | 18 +++ db/schema_migrations/20210506064413 | 1 + db/structure.sql | 2 + doc/api/graphql/reference/index.md | 3 +- doc/user/group/devops_adoption/index.md | 21 +-- doc/user/project/clusters/add_eks_clusters.md | 12 +- doc/user/project/time_tracking.md | 5 + lib/gitlab/blob_helper.rb | 16 +- lib/gitlab/ci/reports/codequality_mr_diff.rb | 6 +- .../ci/templates/OpenShift.gitlab-ci.yml | 24 ++- lib/gitlab/diff/highlight.rb | 11 +- lib/gitlab/encoding_helper.rb | 31 +++- lib/gitlab/git/blob.rb | 4 +- lib/gitlab/git/repository.rb | 6 +- lib/gitlab/gitaly_client/blobs_stitcher.rb | 2 +- lib/gitlab/gitaly_client/remote_service.rb | 19 ++- lib/gitlab/highlight.rb | 21 ++- .../known_events/ecosystem.yml | 10 -- .../projects/menus/confluence_menu.rb | 43 +++++ .../projects/menus/external_wiki_menu.rb | 52 ++++++ lib/sidebars/projects/menus/wiki_menu.rb | 41 +++++ lib/sidebars/projects/panel.rb | 10 ++ locale/gitlab.pot | 24 ++- qa/qa/page/project/menu.rb | 6 +- .../autocomplete_sources_controller_spec.rb | 69 ++++++++ spec/factories/ci/builds.rb | 6 + .../groups/members/manage_groups_spec.rb | 54 +++++-- spec/features/groups/milestone_spec.rb | 4 +- .../milestones/gfm_autocomplete_spec.rb | 80 +++++++++ ...e_for_discussions_in_merge_request_spec.rb | 2 +- ...epending_on_unresolved_discussions_spec.rb | 2 +- .../features/projects/diffs/diff_show_spec.rb | 2 +- .../projects/members/invite_group_spec.rb | 115 ++++++++----- .../milestones/gfm_autocomplete_spec.rb | 80 +++++++++ .../code_quality_mr_diff.json | 42 ++--- .../components/devops_score_spec.js | 153 +++++++++++------- .../admin/analytics/devops_score/mock_data.js | 52 +++--- .../mr_widget_unresolved_discussions_spec.js | 8 +- spec/graphql/types/timelog_type_spec.rb | 10 +- spec/helpers/application_helper_spec.rb | 29 +++- spec/helpers/dev_ops_report_helper_spec.rb | 6 + .../ci/reports/codequality_mr_diff_spec.rb | 15 +- .../codequality_reports_comparer_spec.rb | 2 +- spec/lib/gitlab/diff/highlight_spec.rb | 32 +++- spec/lib/gitlab/encoding_helper_spec.rb | 59 +++++++ spec/lib/gitlab/git/blame_spec.rb | 5 +- spec/lib/gitlab/git/repository_spec.rb | 10 +- .../gitaly_client/remote_service_spec.rb | 52 ++++-- spec/lib/gitlab/highlight_spec.rb | 34 ++++ .../projects/menus/confluence_menu_spec.rb | 44 +++++ .../projects/menus/external_wiki_menu_spec.rb | 39 +++++ .../sidebars/projects/menus/wiki_menu_spec.rb | 31 ++++ spec/lib/sidebars/projects/panel_spec.rb | 28 ++++ .../concerns/has_timelogs_report_spec.rb | 22 +-- spec/models/merge_request_spec.rb | 2 +- spec/models/timelog_spec.rb | 37 +++-- .../code_quality_mr_diff_presenter_spec.rb | 3 +- .../requests/api/graphql/ci/pipelines_spec.rb | 81 ++++++++++ .../ci/codequality_mr_diff_entity_spec.rb | 10 +- ...equality_mr_diff_report_serializer_spec.rb | 10 +- ...group_issuable_autocomplete_entity_spec.rb | 17 ++ ...codequality_mr_diff_report_service_spec.rb | 4 +- ...ode_quality_mr_diff_report_service_spec.rb | 90 ++++++----- .../groups/autocomplete_service_spec.rb | 119 ++++++++++++++ .../nav/sidebar/_project.html.haml_spec.rb | 72 ++++----- .../create_quality_report_worker_spec.rb | 4 +- workhorse/internal/upstream/routes.go | 3 + workhorse/upload_test.go | 5 + 134 files changed, 1987 insertions(+), 562 deletions(-) rename app/{views/shared/icons/_dev_ops_report_no_data.svg => assets/images/dev_ops_report_no_data.svg} (100%) rename app/assets/javascripts/analytics/devops_report/{devops_score_empty_state.js => devops_score_disabled_usage_ping.js} (96%) rename app/assets/javascripts/pages/groups/settings/packages_and_registries/{ => show}/index.js (100%) rename app/assets/javascripts/pages/projects/settings/packages_and_registries/{index => show}/index.js (100%) delete mode 100644 app/assets/stylesheets/page_bundles/dev_ops_report.scss create mode 100644 app/controllers/groups/autocomplete_sources_controller.rb create mode 100644 app/policies/ci/stage_policy.rb create mode 100644 app/serializers/group_issuable_autocomplete_entity.rb create mode 100644 app/serializers/group_issuable_autocomplete_serializer.rb create mode 100644 app/services/groups/autocomplete_service.rb create mode 100644 app/services/groups/participants_service.rb delete mode 100644 app/views/admin/dev_ops_report/_no_data.html.haml rename app/views/groups/settings/packages_and_registries/{index.html.haml => show.html.haml} (100%) rename app/views/projects/settings/packages_and_registries/{index.html.haml => show.html.haml} (100%) create mode 100644 changelogs/unreleased/271244-fe-devops-report-convert-score-page-to-vue-components-2.yml create mode 100644 changelogs/unreleased/322017-updating-hover-focus-states-on-pipeline-buttons.yml create mode 100644 changelogs/unreleased/329695-add-read_commit_status-field-authorization-to-pipeline-fields-that.yml create mode 100644 changelogs/unreleased/330086-inverse-index-on-namespaces-parent_id-id.yml create mode 100644 changelogs/unreleased/expose-mr-timelogs-via-graphql.yml create mode 100644 changelogs/unreleased/feat-milestone-description-auto-complete.yml create mode 100644 changelogs/unreleased/fix-openshift-template-to-run-on-main-branch.yml create mode 100644 changelogs/unreleased/mo-fix-codequality-mr-diff-report.yml create mode 100644 changelogs/unreleased/remove-usage_data_track_ecosystem_slack_service-feature-flag.yml rename config/feature_flags/development/{usage_data_track_ecosystem_slack_service.yml => cached_encoding_detection.yml} (60%) create mode 100644 config/feature_flags/development/find_remote_root_refs_inmemory.yml create mode 100644 config/feature_flags/development/limited_diff_highlighting.yml rename config/feature_flags/development/{ci_no_empty_groups.yml => track_highlight_timeouts.yml} (63%) create mode 100644 db/post_migrate/20210506064413_create_namespaces_id_parent_id_inverse_partial_index.rb create mode 100644 db/schema_migrations/20210506064413 create mode 100644 lib/sidebars/projects/menus/confluence_menu.rb create mode 100644 lib/sidebars/projects/menus/external_wiki_menu.rb create mode 100644 lib/sidebars/projects/menus/wiki_menu.rb create mode 100644 spec/controllers/groups/autocomplete_sources_controller_spec.rb create mode 100644 spec/features/groups/milestones/gfm_autocomplete_spec.rb create mode 100644 spec/features/projects/milestones/gfm_autocomplete_spec.rb create mode 100644 spec/lib/sidebars/projects/menus/confluence_menu_spec.rb create mode 100644 spec/lib/sidebars/projects/menus/external_wiki_menu_spec.rb create mode 100644 spec/lib/sidebars/projects/menus/wiki_menu_spec.rb create mode 100644 spec/serializers/group_issuable_autocomplete_entity_spec.rb create mode 100644 spec/services/groups/autocomplete_service_spec.rb diff --git a/.gitlab/issue_templates/Feature Flag Roll Out.md b/.gitlab/issue_templates/Feature Flag Roll Out.md index 86083c565fb..39f4de94553 100644 --- a/.gitlab/issue_templates/Feature Flag Roll Out.md +++ b/.gitlab/issue_templates/Feature Flag Roll Out.md @@ -75,7 +75,10 @@ Are there any other stages or teams involved that need to be kept in the loop? issue](https://about.gitlab.com/handbook/engineering/infrastructure/change-management/#feature-flags-and-the-change-management-process). Cross link the issue here if it does. +- [ ] Ensure that you or a representative in development can be available for at least 2 hours after feature flag updates in production. If a different developer will be covering, or an exception is needed, please inform the oncall SRE by using the `@sre-oncall` Slack alias. + *Partial Rollout Phase* + - [ ] Enable on GitLab.com for individual groups/projects listed above and verify behaviour (`/chatops run feature set --project=gitlab-org/gitlab feature_name true`) - [ ] Verify behaviour (See Beta Groups) and add details with screenshots as a comment on this issue diff --git a/.rubocop_manual_todo.yml b/.rubocop_manual_todo.yml index c1285c77e01..eba11804513 100644 --- a/.rubocop_manual_todo.yml +++ b/.rubocop_manual_todo.yml @@ -1998,6 +1998,8 @@ Gitlab/NamespacedClass: - 'app/serializers/group_entity.rb' - 'app/serializers/group_group_link_entity.rb' - 'app/serializers/group_group_link_serializer.rb' + - 'app/serializers/group_issuable_autocomplete_entity.rb' + - 'app/serializers/group_issuable_autocomplete_serializer.rb' - 'app/serializers/group_serializer.rb' - 'app/serializers/issuable_entity.rb' - 'app/serializers/issuable_sidebar_basic_entity.rb' @@ -2500,8 +2502,6 @@ Gitlab/NamespacedClass: - 'ee/app/serializers/geo_project_registry_entity.rb' - 'ee/app/serializers/geo_project_registry_serializer.rb' - 'ee/app/serializers/group_analytics_serializer.rb' - - 'ee/app/serializers/group_issuable_autocomplete_entity.rb' - - 'ee/app/serializers/group_issuable_autocomplete_serializer.rb' - 'ee/app/serializers/group_vulnerability_autocomplete_entity.rb' - 'ee/app/serializers/group_vulnerability_autocomplete_serializer.rb' - 'ee/app/serializers/invited_group_entity.rb' diff --git a/GITALY_SERVER_VERSION b/GITALY_SERVER_VERSION index b15a3879a77..e70d1d0105b 100644 --- a/GITALY_SERVER_VERSION +++ b/GITALY_SERVER_VERSION @@ -1 +1 @@ -1481a9195c200e375a177cf201058b88bebe271b +c67f1a2bb56d8fa3403b529fd3bf36dba3a6488c diff --git a/Gemfile b/Gemfile index 9cd928d5fd8..3504041ec6c 100644 --- a/Gemfile +++ b/Gemfile @@ -481,7 +481,7 @@ end gem 'spamcheck', '~> 0.0.5' # Gitaly GRPC protocol definitions -gem 'gitaly', '~> 13.11.0.pre.rc1' +gem 'gitaly', '~> 13.12.0.pre.rc1' gem 'grpc', '~> 1.30.2' diff --git a/Gemfile.lock b/Gemfile.lock index 8111ff597e7..643cb7046c9 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -439,7 +439,7 @@ GEM rails (>= 3.2.0) git (1.7.0) rchardet (~> 1.8) - gitaly (13.11.0.pre.rc1) + gitaly (13.12.0.pre.rc1) grpc (~> 1.0) github-markup (1.7.0) gitlab (4.16.1) @@ -1446,7 +1446,7 @@ DEPENDENCIES gettext (~> 3.3) gettext_i18n_rails (~> 1.8.0) gettext_i18n_rails_js (~> 1.3) - gitaly (~> 13.11.0.pre.rc1) + gitaly (~> 13.12.0.pre.rc1) github-markup (~> 1.7.0) gitlab-chronic (~> 0.10.5) gitlab-dangerfiles (~> 2.0.0) diff --git a/app/views/shared/icons/_dev_ops_report_no_data.svg b/app/assets/images/dev_ops_report_no_data.svg similarity index 100% rename from app/views/shared/icons/_dev_ops_report_no_data.svg rename to app/assets/images/dev_ops_report_no_data.svg diff --git a/app/assets/javascripts/analytics/devops_report/components/devops_score.vue b/app/assets/javascripts/analytics/devops_report/components/devops_score.vue index 7dc552623f6..1a3289ffb75 100644 --- a/app/assets/javascripts/analytics/devops_report/components/devops_score.vue +++ b/app/assets/javascripts/analytics/devops_report/components/devops_score.vue @@ -1,5 +1,5 @@