From 26dfad7651130842a18a3c05c7a9731084da1695 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Thu, 3 Nov 2022 03:10:45 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .rubocop_todo/layout/space_inside_parens.yml | 14 - GITLAB_KAS_VERSION | 2 +- Gemfile | 2 +- Gemfile.checksum | 2 +- Gemfile.lock | 4 +- .../components/issues_dashboard_app.vue | 56 ++ .../javascripts/issues/dashboard/index.js | 25 + .../components/list_page/image_list_row.vue | 22 +- .../pages/dashboard/issues/index.js | 3 + .../filtered_search_bar_root.vue | 2 +- .../components/work_item_links/index.js | 4 - .../stylesheets/page_bundles/dashboard.scss | 5 + .../registry/repositories_controller.rb | 4 - .../jira_connect/subscriptions_controller.rb | 3 +- .../projects/application_controller.rb | 6 +- .../projects/incidents_controller.rb | 1 - app/controllers/projects/issues_controller.rb | 1 - .../registry/repositories_controller.rb | 4 - .../projects/work_items_controller.rb | 1 - app/controllers/projects_controller.rb | 1 - app/helpers/appearances_helper.rb | 2 +- app/models/ci/build.rb | 3 +- app/models/wiki.rb | 96 ++- .../widgets/hierarchy_service/base_service.rb | 9 - app/views/dashboard/issues.html.haml | 27 +- .../issues/_work_item_links.html.haml | 3 +- config/application.rb | 1 + ...ened_path.yml => vue_issues_dashboard.yml} | 10 +- .../development/work_items_hierarchy.yml | 8 - ...mmit_committer_name_check_to_push_rules.rb | 7 + ...inding_data_column_to_security_findings.rb | 13 + ...bility_occurrences_uuid_type_transition.rb | 26 + ...ransition_from_state_not_equal_to_state.rb | 19 + db/schema_migrations/20220927171740 | 1 + db/schema_migrations/20221025115006 | 1 + db/schema_migrations/20221028015347 | 1 + db/schema_migrations/20221028152422 | 1 + db/structure.sql | 19 +- doc/.vale/gitlab/Wordy.yml | 1 + doc/api/runners.md | 60 +- doc/user/application_security/sast/index.md | 2 + .../reducing_the_repo_size_using_git.md | 45 +- doc/user/tasks.md | 2 +- lib/api/api.rb | 2 +- lib/api/ci/runners.rb | 628 ++++++++++-------- .../common/pipelines/wiki_pipeline.rb | 2 +- lib/gitlab/database/migration_helpers.rb | 125 +++- locale/gitlab.pot | 11 +- .../projects/artifacts_controller_spec.rb | 5 +- .../projects/jobs_controller_spec.rb | 85 ++- .../projects/jobs/permissions_spec.rb | 44 ++ .../work_items/work_item_children_spec.rb | 1 - .../components/issues_dashboard_app_spec.js | 58 ++ .../list_page/image_list_row_spec.js | 60 +- spec/helpers/appearances_helper_spec.rb | 9 + .../gitlab/database/migration_helpers_spec.rb | 106 ++- spec/models/ci/build_spec.rb | 54 ++ spec/requests/api/ci/jobs_spec.rb | 26 + .../subscriptions_controller_spec.rb | 4 +- ...ative_position_rebalancing_service_spec.rb | 4 - .../work_items/create_service_spec.rb | 10 - .../hierarchy_service/update_service_spec.rb | 22 - spec/spec_helper.rb | 4 + .../pipelines/wiki_pipeline_examples.rb | 4 +- .../models/wiki_shared_examples.rb | 23 - 65 files changed, 1180 insertions(+), 626 deletions(-) create mode 100644 app/assets/javascripts/issues/dashboard/components/issues_dashboard_app.vue create mode 100644 app/assets/javascripts/issues/dashboard/index.js create mode 100644 app/assets/stylesheets/page_bundles/dashboard.scss rename config/feature_flags/development/{container_registry_show_shortened_path.yml => vue_issues_dashboard.yml} (61%) delete mode 100644 config/feature_flags/development/work_items_hierarchy.yml create mode 100644 db/migrate/20221028015347_add_commit_committer_name_check_to_push_rules.rb create mode 100644 db/migrate/20221028152422_add_finding_data_column_to_security_findings.rb create mode 100644 db/post_migrate/20220927171740_prepare_for_vulnerability_occurrences_uuid_type_transition.rb create mode 100644 db/post_migrate/20221025115006_check_vulnerabilities_state_transition_from_state_not_equal_to_state.rb create mode 100644 db/schema_migrations/20220927171740 create mode 100644 db/schema_migrations/20221025115006 create mode 100644 db/schema_migrations/20221028015347 create mode 100644 db/schema_migrations/20221028152422 create mode 100644 spec/frontend/issues/dashboard/components/issues_dashboard_app_spec.js diff --git a/.rubocop_todo/layout/space_inside_parens.yml b/.rubocop_todo/layout/space_inside_parens.yml index cf33828b20f..e6238992619 100644 --- a/.rubocop_todo/layout/space_inside_parens.yml +++ b/.rubocop_todo/layout/space_inside_parens.yml @@ -7,20 +7,6 @@ Layout/SpaceInsideParens: Exclude: - 'config/initializers/wikicloth_redos_patch.rb' - 'db/post_migrate/20210722042939_update_issuable_slas_where_issue_closed.rb' - - 'ee/app/graphql/resolvers/external_issue_resolver.rb' - - 'ee/app/helpers/billing_plans_helper.rb' - - 'ee/app/helpers/ee/boards_helper.rb' - - 'ee/app/models/ee/lfs_object.rb' - - 'ee/app/models/ee/merge_request_diff.rb' - - 'ee/app/models/ee/pages_deployment.rb' - - 'ee/app/models/ee/upload.rb' - - 'ee/app/models/requirements_management/requirement.rb' - - 'ee/app/models/resource_iteration_event.rb' - - 'ee/app/services/compliance_management/frameworks/create_service.rb' - - 'ee/app/services/compliance_management/frameworks/destroy_service.rb' - - 'ee/app/services/compliance_management/frameworks/update_service.rb' - - 'ee/app/services/elastic/cluster_reindexing_service.rb' - - 'ee/app/services/sitemap/create_service.rb' - 'ee/lib/ee/gitlab/auth/ldap/access.rb' - 'ee/lib/gitlab/auth/smartcard/session.rb' - 'ee/spec/finders/ee/alert_management/http_integrations_finder_spec.rb' diff --git a/GITLAB_KAS_VERSION b/GITLAB_KAS_VERSION index b8402259306..c85078ffaa1 100644 --- a/GITLAB_KAS_VERSION +++ b/GITLAB_KAS_VERSION @@ -1 +1 @@ -15.6.0-rc1 +15.6.0-rc2 diff --git a/Gemfile b/Gemfile index 0f74cfc0f61..6cbb1a4351f 100644 --- a/Gemfile +++ b/Gemfile @@ -362,7 +362,7 @@ gem 'prometheus-client-mmap', '~> 0.16', require: 'prometheus/client' gem 'warning', '~> 1.3.0' group :development do - gem 'lefthook', '~> 1.1.3', require: false + gem 'lefthook', '~> 1.1.4', require: false gem 'rubocop' gem 'solargraph', '~> 0.47.2', require: false diff --git a/Gemfile.checksum b/Gemfile.checksum index 4ef340ff894..09bbd1fa875 100644 --- a/Gemfile.checksum +++ b/Gemfile.checksum @@ -302,7 +302,7 @@ {"name":"kramdown-parser-gfm","version":"1.1.0","platform":"ruby","checksum":"fb39745516427d2988543bf01fc4cf0ab1149476382393e0e9c48592f6581729"}, {"name":"kubeclient","version":"4.9.3","platform":"ruby","checksum":"d5d38e719fbac44f396851aa57cd1b9f4f7dab4410ab680ccd21c9b741230046"}, {"name":"launchy","version":"2.5.0","platform":"ruby","checksum":"954243c4255920982ce682f89a42e76372dba94770bf09c23a523e204bdebef5"}, -{"name":"lefthook","version":"1.1.3","platform":"ruby","checksum":"3f8337b2176f49e6d4ab8f0f4494c8d1be0548d79bca898fbf2184d717092b75"}, +{"name":"lefthook","version":"1.1.4","platform":"ruby","checksum":"251fbc6681a7d0f05e594b5091206998fd21060285f9752ac40b92441d5eb93c"}, {"name":"letter_opener","version":"1.7.0","platform":"ruby","checksum":"095bc0d58e006e5b43ea7d219e64ecf2de8d1f7d9dafc432040a845cf59b4725"}, {"name":"letter_opener_web","version":"2.0.0","platform":"ruby","checksum":"33860ad41e1785d75456500e8ca8bba8ed71ee6eaf08a98d06bbab67c5577b6f"}, {"name":"libyajl2","version":"1.2.0","platform":"ruby","checksum":"1117cd1e48db013b626e36269bbf1cef210538ca6d2e62d3fa3db9ded005b258"}, diff --git a/Gemfile.lock b/Gemfile.lock index cdd22499a82..6d8244cadcb 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -802,7 +802,7 @@ GEM rest-client (~> 2.0) launchy (2.5.0) addressable (~> 2.7) - lefthook (1.1.3) + lefthook (1.1.4) letter_opener (1.7.0) launchy (~> 2.2) letter_opener_web (2.0.0) @@ -1680,7 +1680,7 @@ DEPENDENCIES knapsack (~> 1.21.1) kramdown (~> 2.3.1) kubeclient (~> 4.9.3) - lefthook (~> 1.1.3) + lefthook (~> 1.1.4) letter_opener_web (~> 2.0.0) license_finder (~> 7.0) licensee (~> 9.15) diff --git a/app/assets/javascripts/issues/dashboard/components/issues_dashboard_app.vue b/app/assets/javascripts/issues/dashboard/components/issues_dashboard_app.vue new file mode 100644 index 00000000000..29f6aecca03 --- /dev/null +++ b/app/assets/javascripts/issues/dashboard/components/issues_dashboard_app.vue @@ -0,0 +1,56 @@ + + + diff --git a/app/assets/javascripts/issues/dashboard/index.js b/app/assets/javascripts/issues/dashboard/index.js new file mode 100644 index 00000000000..a1ae3b93f7d --- /dev/null +++ b/app/assets/javascripts/issues/dashboard/index.js @@ -0,0 +1,25 @@ +import Vue from 'vue'; +import { parseBoolean } from '~/lib/utils/common_utils'; +import IssuesDashboardApp from './components/issues_dashboard_app.vue'; + +export function mountIssuesDashboardApp() { + const el = document.querySelector('.js-issues-dashboard'); + + if (!el) { + return null; + } + + const { calendarPath, emptyStateSvgPath, isSignedIn, rssPath } = el.dataset; + + return new Vue({ + el, + name: 'IssuesDashboardRoot', + provide: { + calendarPath, + emptyStateSvgPath, + isSignedIn: parseBoolean(isSignedIn), + rssPath, + }, + render: (createComponent) => createComponent(IssuesDashboardApp), + }); +} diff --git a/app/assets/javascripts/packages_and_registries/container_registry/explorer/components/list_page/image_list_row.vue b/app/assets/javascripts/packages_and_registries/container_registry/explorer/components/list_page/image_list_row.vue index 80bca536b7c..23d8e97dd79 100644 --- a/app/assets/javascripts/packages_and_registries/container_registry/explorer/components/list_page/image_list_row.vue +++ b/app/assets/javascripts/packages_and_registries/container_registry/explorer/components/list_page/image_list_row.vue @@ -3,7 +3,6 @@ import { GlTooltipDirective, GlIcon, GlSprintf, GlSkeletonLoader, GlButton } fro import { getIdFromGraphQLId } from '~/graphql_shared/utils'; import { n__ } from '~/locale'; import Tracking from '~/tracking'; -import glFeatureFlagsMixin from '~/vue_shared/mixins/gl_feature_flags_mixin'; import ClipboardButton from '~/vue_shared/components/clipboard_button.vue'; import ListItem from '~/vue_shared/components/registry/list_item.vue'; import { joinPaths } from '~/lib/utils/url_utility'; @@ -38,7 +37,7 @@ export default { directives: { GlTooltip: GlTooltipDirective, }, - mixins: [Tracking.mixin(), glFeatureFlagsMixin()], + mixins: [Tracking.mixin()], inject: ['config'], props: { item: { @@ -91,17 +90,14 @@ export default { ); }, imageName() { - if (this.glFeatures.containerRegistryShowShortenedPath) { - if (this.showFullPath) { - return this.item.path; - } - const projectPath = this.item?.project?.path?.toLowerCase() ?? ''; - if (this.item.name) { - return joinPaths(projectPath, this.item.name); - } - return projectPath; + if (this.showFullPath) { + return this.item.path; } - return this.item.path; + const projectPath = this.item?.project?.path?.toLowerCase() ?? ''; + if (this.item.name) { + return joinPaths(projectPath, this.item.name); + } + return projectPath; }, routerLinkEvent() { return this.deleting ? '' : 'click'; @@ -136,7 +132,7 @@ export default { >