From 279412f90a58b2bfa939e82c2f90aa0cac2c715b Mon Sep 17 00:00:00 2001 From: James Lopez Date: Tue, 14 Jun 2016 10:55:24 +0200 Subject: [PATCH] updated relation_factory based on MR feedback --- lib/gitlab/import_export/relation_factory.rb | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/gitlab/import_export/relation_factory.rb b/lib/gitlab/import_export/relation_factory.rb index 5f12caa8981..4e4ce4f14a9 100644 --- a/lib/gitlab/import_export/relation_factory.rb +++ b/lib/gitlab/import_export/relation_factory.rb @@ -57,11 +57,11 @@ module Gitlab author = @relation_hash.delete('author') - update_note_for_missing_author(author['name']) if can_update_notes? + update_note_for_missing_author(author['name']) if missing_author? end - def can_update_notes? - (admin_user? && @members_mapper.missing_author_ids.include?(old_author_id)) || !admin_user? + def missing_author? + !admin_user? || @members_mapper.missing_author_ids.include?(old_author_id) end def missing_author_note(updated_at, author_name)