Merge branch 'sh-optimize-label-finder' into 'master'

Reduce overhead of LabelFinder by avoiding #presence call

Some users experienced 502 timeouts when viewing group labels.
Labels#open_issues_count and Label#open_merge_requests_count were
taking a long time to load because they were loading every ActiveRecord
of the user-accessible projects into memory. This change modifies so
that only the IDs are loaded into memory.

Closes #23684

See merge request !7094
This commit is contained in:
Stan Hu 2016-10-25 15:55:59 +00:00
commit 279ffe7bff
2 changed files with 2 additions and 1 deletions

View File

@ -22,6 +22,7 @@ Please view this file on the master branch, on stable branches it's out of date.
- Fix reply-by-email not working due to queue name mismatch
- Fixed hidden pipeline graph on commit and MR page !6895
- Expire and build repository cache after project import
- Reduce overhead of LabelFinder by avoiding #presence call !7094
- Fix 404 for group pages when GitLab setup uses relative url
- Simpler arguments passed to named_route on toggle_award_url helper method
- Fix unauthorized users dragging on issue boards

View File

@ -50,7 +50,7 @@ class LabelsFinder < UnionFinder
end
def projects_ids
params[:project_ids].presence
params[:project_ids]
end
def title