Maintain commit order in MRs
`Gitlab::Git::Compare` will already have the correct order; sorting in Ruby can only ruin that. (The correct order being the same as `git log` - reverse chronological while maintaining the commit graph.) As an example, imagine a branch where someone has their system clock set wrong for some of the commits. Not only will those commits be in the wrong order - which is maybe reasonable - but sorting in Ruby can also put commits with the same timestamp out of order, as Ruby's sorting isn't stable.
This commit is contained in:
parent
636b3ebb01
commit
27fdd3fe50
1 changed files with 1 additions and 3 deletions
|
@ -98,9 +98,7 @@ class MergeRequestDiff < ActiveRecord::Base
|
||||||
commits = compare.commits
|
commits = compare.commits
|
||||||
|
|
||||||
if commits.present?
|
if commits.present?
|
||||||
commits = Commit.decorate(commits, merge_request.source_project).
|
commits = Commit.decorate(commits, merge_request.source_project).reverse
|
||||||
sort_by(&:created_at).
|
|
||||||
reverse
|
|
||||||
end
|
end
|
||||||
|
|
||||||
commits
|
commits
|
||||||
|
|
Loading…
Reference in a new issue