Cannot mark a Commit as todo via `/todo`
This commit is contained in:
parent
56ce46674f
commit
2881886417
|
@ -301,7 +301,8 @@ module QuickActions
|
||||||
desc 'Add a todo'
|
desc 'Add a todo'
|
||||||
explanation 'Adds a todo.'
|
explanation 'Adds a todo.'
|
||||||
condition do
|
condition do
|
||||||
issuable.persisted? &&
|
issuable.is_a?(Issuable) &&
|
||||||
|
issuable.persisted? &&
|
||||||
!TodoService.new.todo_exist?(issuable, current_user)
|
!TodoService.new.todo_exist?(issuable, current_user)
|
||||||
end
|
end
|
||||||
command :todo do
|
command :todo do
|
||||||
|
|
|
@ -637,16 +637,6 @@ describe QuickActions::InterpretService do
|
||||||
let(:issuable) { merge_request }
|
let(:issuable) { merge_request }
|
||||||
end
|
end
|
||||||
|
|
||||||
it_behaves_like 'todo command' do
|
|
||||||
let(:content) { '/todo' }
|
|
||||||
let(:issuable) { issue }
|
|
||||||
end
|
|
||||||
|
|
||||||
it_behaves_like 'todo command' do
|
|
||||||
let(:content) { '/todo' }
|
|
||||||
let(:issuable) { merge_request }
|
|
||||||
end
|
|
||||||
|
|
||||||
it_behaves_like 'done command' do
|
it_behaves_like 'done command' do
|
||||||
let(:content) { '/done' }
|
let(:content) { '/done' }
|
||||||
let(:issuable) { issue }
|
let(:issuable) { issue }
|
||||||
|
@ -796,6 +786,28 @@ describe QuickActions::InterpretService do
|
||||||
let(:issuable) { issue }
|
let(:issuable) { issue }
|
||||||
end
|
end
|
||||||
|
|
||||||
|
context '/todo' do
|
||||||
|
let(:content) { '/todo' }
|
||||||
|
|
||||||
|
context 'if issuable is an Issue' do
|
||||||
|
it_behaves_like 'todo command' do
|
||||||
|
let(:issuable) { issue }
|
||||||
|
end
|
||||||
|
end
|
||||||
|
|
||||||
|
context 'if issuable is a MergeRequest' do
|
||||||
|
it_behaves_like 'todo command' do
|
||||||
|
let(:issuable) { merge_request }
|
||||||
|
end
|
||||||
|
end
|
||||||
|
|
||||||
|
context 'if issuable is a Commit' do
|
||||||
|
it_behaves_like 'empty command' do
|
||||||
|
let(:issuable) { commit }
|
||||||
|
end
|
||||||
|
end
|
||||||
|
end
|
||||||
|
|
||||||
context '/copy_metadata command' do
|
context '/copy_metadata command' do
|
||||||
let(:todo_label) { create(:label, project: project, title: 'To Do') }
|
let(:todo_label) { create(:label, project: project, title: 'To Do') }
|
||||||
let(:inreview_label) { create(:label, project: project, title: 'In Review') }
|
let(:inreview_label) { create(:label, project: project, title: 'In Review') }
|
||||||
|
|
Loading…
Reference in New Issue