Merge branch 'acet-mr-diffs-autosave' into 'master'
Implement MR diff notes autosave feature Closes #48300 See merge request gitlab-org/gitlab-ce!20114
This commit is contained in:
commit
292cf66890
3 changed files with 41 additions and 2 deletions
|
@ -1,9 +1,12 @@
|
|||
<script>
|
||||
import $ from 'jquery';
|
||||
import { mapState, mapGetters, mapActions } from 'vuex';
|
||||
import createFlash from '~/flash';
|
||||
import { s__ } from '~/locale';
|
||||
import noteForm from '../../notes/components/note_form.vue';
|
||||
import { getNoteFormData } from '../store/utils';
|
||||
import Autosave from '../../autosave';
|
||||
import { DIFF_NOTE_TYPE, NOTE_TYPE } from '../constants';
|
||||
|
||||
export default {
|
||||
components: {
|
||||
|
@ -37,11 +40,28 @@ export default {
|
|||
noteableData: state => state.notes.noteableData,
|
||||
diffViewType: state => state.diffs.diffViewType,
|
||||
}),
|
||||
...mapGetters(['noteableType', 'getNotesDataByProp']),
|
||||
...mapGetters(['isLoggedIn', 'noteableType', 'getNoteableData', 'getNotesDataByProp']),
|
||||
},
|
||||
mounted() {
|
||||
if (this.isLoggedIn) {
|
||||
const noteableData = this.getNoteableData;
|
||||
const keys = [
|
||||
NOTE_TYPE,
|
||||
this.noteableType,
|
||||
noteableData.id,
|
||||
noteableData.diff_head_sha,
|
||||
DIFF_NOTE_TYPE,
|
||||
noteableData.source_project_id,
|
||||
this.line.lineCode,
|
||||
];
|
||||
|
||||
this.autosave = new Autosave($(this.$refs.noteForm.$refs.textarea), keys);
|
||||
}
|
||||
},
|
||||
methods: {
|
||||
...mapActions(['cancelCommentForm', 'saveNote', 'fetchDiscussions']),
|
||||
handleCancelCommentForm() {
|
||||
this.autosave.reset();
|
||||
this.cancelCommentForm({
|
||||
lineCode: this.line.lineCode,
|
||||
});
|
||||
|
@ -82,6 +102,7 @@ export default {
|
|||
class="content discussion-form discussion-form-container discussion-notes"
|
||||
>
|
||||
<note-form
|
||||
ref="noteForm"
|
||||
:is-editing="true"
|
||||
:line-code="line.lineCode"
|
||||
save-button-title="Comment"
|
||||
|
|
|
@ -7,6 +7,7 @@ export const CONTEXT_LINE_TYPE = 'context';
|
|||
export const EMPTY_CELL_TYPE = 'empty-cell';
|
||||
export const COMMENT_FORM_TYPE = 'commentForm';
|
||||
export const DIFF_NOTE_TYPE = 'DiffNote';
|
||||
export const NOTE_TYPE = 'Note';
|
||||
export const NEW_LINE_TYPE = 'new';
|
||||
export const OLD_LINE_TYPE = 'old';
|
||||
export const TEXT_DIFF_POSITION_TYPE = 'text';
|
||||
|
|
|
@ -19,7 +19,15 @@ describe('DiffLineNoteForm', () => {
|
|||
diffLines,
|
||||
line: diffLines[0],
|
||||
noteTargetLine: diffLines[0],
|
||||
}).$mount();
|
||||
});
|
||||
|
||||
Object.defineProperty(component, 'isLoggedIn', {
|
||||
get() {
|
||||
return true;
|
||||
},
|
||||
});
|
||||
|
||||
component.$mount();
|
||||
});
|
||||
|
||||
describe('methods', () => {
|
||||
|
@ -56,6 +64,15 @@ describe('DiffLineNoteForm', () => {
|
|||
});
|
||||
});
|
||||
|
||||
describe('mounted', () => {
|
||||
it('should init autosave', () => {
|
||||
const key = 'autosave/Note/issue///DiffNote//1c497fbb3a46b78edf04cc2a2fa33f67e3ffbe2a_1_1';
|
||||
|
||||
expect(component.autosave).toBeDefined();
|
||||
expect(component.autosave.key).toEqual(key);
|
||||
});
|
||||
});
|
||||
|
||||
describe('template', () => {
|
||||
it('should have note form', () => {
|
||||
const { $el } = component;
|
||||
|
|
Loading…
Reference in a new issue