kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Add missing aria-hidden attribute to i tags

Browse source
This commit is contained in:
Alfredo Sumaran 2017-06-08 02:34:38 -05:00
parent ec7f906b56
commit 2a33752cb4
1 changed files with 21 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

29
app/assets/javascripts/groups/components/group_item.vue
View file

@ -110,7 +110,11 @@ export default {
v-if="group.canEdit" v-if="group.canEdit"
class="edit-group btn" class="edit-group btn"
:href="group.editPath"> :href="group.editPath">
<i aria-hidden="true" class="fa fa-cogs"></i> <i
class="fa fa-cogs"
aria-hidden="true"
>
</i>
</a> </a>
<a <a
@click="onLeaveGroup" @click="onLeaveGroup"
@ -118,8 +122,9 @@ export default {
class="leave-group btn" class="leave-group btn"
title="Leave this group"> title="Leave this group">
<i <i
class="fa fa-sign-out"
aria-hidden="true" aria-hidden="true"
class="fa fa-sign-out"> >
</i> </i>
</a> </a>
</div> </div>
@ -128,24 +133,27 @@ export default {
<span <span
class="number-projects"> class="number-projects">
<i <i
class="fa fa-bookmark"
aria-hidden="true" aria-hidden="true"
class="fa fa-bookmark"> >
</i> </i>
{{group.numberProjects}} {{group.numberProjects}}
</span> </span>
<span <span
class="number-users"> class="number-users">
<i <i
class="fa fa-users"
aria-hidden="true" aria-hidden="true"
class="fa fa-users"> >
</i> </i>
{{group.numberUsers}} {{group.numberUsers}}
</span> </span>
<span <span
class="group-visibility"> class="group-visibility">
<i <i
:class="visibilityIcon"
aria-hidden="true" aria-hidden="true"
:class="visibilityIcon"> >
</i> </i>
</span> </span>
</div> </div>
@ -156,18 +164,23 @@ export default {
v-if="group.hasSubgroups"> v-if="group.hasSubgroups">
<i <i
v-if="group.isOpen" v-if="group.isOpen"
class="fa fa-caret-down"> class="fa fa-caret-down"
aria-hidden="true"
>
</i> </i>
<i <i
v-if="!group.isOpen" v-if="!group.isOpen"
class="fa fa-caret-right"> class="fa fa-caret-right"
aria-hidden="true"
>
</i> </i>
</span> </span>
<span class="folder-icon"> <span class="folder-icon">
<i <i
v-if="group.isOpen" v-if="group.isOpen"
class="fa fa-folder-open" class="fa fa-folder-open"
aria-hidden="true"> aria-hidden="true"
>
</i> </i>
<i <i
v-if="!group.isOpen" v-if="!group.isOpen"