diff --git a/.gitlab/issue_templates/Feature Flag Roll Out.md b/.gitlab/issue_templates/Feature Flag Roll Out.md index d4bd4f66720..3fe72feda57 100644 --- a/.gitlab/issue_templates/Feature Flag Roll Out.md +++ b/.gitlab/issue_templates/Feature Flag Roll Out.md @@ -30,6 +30,17 @@ Are there any other stages or teams involved that need to be kept in the loop? +### When is the feature viable? + + + + + ### What might happen if this goes wrong? diff --git a/.rubocop_manual_todo.yml b/.rubocop_manual_todo.yml index b94dad0e3c7..158de6bf44c 100644 --- a/.rubocop_manual_todo.yml +++ b/.rubocop_manual_todo.yml @@ -467,6 +467,7 @@ RSpec/AnyInstanceOf: - 'ee/spec/models/project_import_state_spec.rb' - 'ee/spec/models/push_rule_spec.rb' - 'ee/spec/presenters/ci/pipeline_presenter_spec.rb' + - 'ee/spec/presenters/projects/security/configuration_presenter_spec.rb' - 'ee/spec/requests/api/geo_nodes_spec.rb' - 'ee/spec/requests/api/graphql/mutations/dast_on_demand_scans/create_spec.rb' - 'ee/spec/requests/api/graphql/mutations/dast_site_profiles/delete_spec.rb' @@ -2399,14 +2400,9 @@ Database/MultipleDatabases: - 'lib/gitlab/database/load_balancing/sticking.rb' - 'lib/gitlab/database/migrations/observers/migration_observer.rb' - 'lib/gitlab/database/migrations/observers/query_log.rb' - - 'lib/gitlab/database/multi_threaded_migration.rb' - 'lib/gitlab/database/partitioning_migration_helpers/backfill_partitioned_table.rb' - - 'lib/gitlab/database/postgresql_adapter/dump_schema_versions_mixin.rb' - - 'lib/gitlab/database/postgresql_database_tasks/load_schema_versions_mixin.rb' - 'lib/gitlab/database.rb' - 'lib/gitlab/database/schema_cache_with_renamed_table.rb' - - 'lib/gitlab/database/schema_migrations/context.rb' - - 'lib/gitlab/database/schema_version_files.rb' - 'lib/gitlab/database/with_lock_retries.rb' - 'lib/gitlab/gitlab_import/importer.rb' - 'lib/gitlab/health_checks/db_check.rb' diff --git a/app/assets/javascripts/boards/components/board_filtered_search.vue b/app/assets/javascripts/boards/components/board_filtered_search.vue index 86f512a5117..6e6ada2d109 100644 --- a/app/assets/javascripts/boards/components/board_filtered_search.vue +++ b/app/assets/javascripts/boards/components/board_filtered_search.vue @@ -42,6 +42,7 @@ export default { types, weight, epicId, + myReactionEmoji, } = this.filterParams; const filteredSearchValue = []; @@ -89,6 +90,13 @@ export default { }); } + if (myReactionEmoji) { + filteredSearchValue.push({ + type: 'my_reaction_emoji', + value: { data: myReactionEmoji, operator: '=' }, + }); + } + if (epicId) { filteredSearchValue.push({ type: 'epic_id', @@ -147,6 +155,13 @@ export default { }); } + if (this.filterParams['not[myReactionEmoji]']) { + filteredSearchValue.push({ + type: 'my_reaction_emoji', + value: { data: this.filterParams['not[myReactionEmoji]'], operator: '!=' }, + }); + } + if (search) { filteredSearchValue.push(search); } @@ -163,6 +178,7 @@ export default { types, weight, epicId, + myReactionEmoji, } = this.filterParams; let notParams = {}; @@ -177,6 +193,7 @@ export default { 'not[milestone_title]': this.filterParams.not.milestoneTitle, 'not[weight]': this.filterParams.not.weight, 'not[epic_id]': this.filterParams.not.epicId, + 'not[my_reaction_emoji]': this.filterParams.not.myReactionEmoji, }, undefined, ); @@ -192,6 +209,7 @@ export default { types, weight, epic_id: getIdFromGraphQLId(epicId), + my_reaction_emoji: myReactionEmoji, }; }, }, @@ -249,6 +267,9 @@ export default { case 'epic_id': filterParams.epicId = filter.value.data; break; + case 'my_reaction_emoji': + filterParams.myReactionEmoji = filter.value.data; + break; case 'filtered-search-term': if (filter.value.data) plainText.push(filter.value.data); break; diff --git a/app/assets/javascripts/boards/components/issue_board_filtered_search.vue b/app/assets/javascripts/boards/components/issue_board_filtered_search.vue index 7af0de2f231..dd4b2b23efc 100644 --- a/app/assets/javascripts/boards/components/issue_board_filtered_search.vue +++ b/app/assets/javascripts/boards/components/issue_board_filtered_search.vue @@ -1,14 +1,20 @@