From 2cba761741967eb6baf797af2ee0a702c2ffbdfe Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Fri, 23 Sep 2022 15:11:09 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .gitlab/ci/build-images.gitlab-ci.yml | 22 +- GITALY_SERVER_VERSION | 2 +- .../diffs/components/diff_file_header.vue | 2 +- .../components/new_top_level_group_alert.vue | 40 +++ .../components/diff_discussion_header.vue | 19 +- .../notes/components/discussion_notes.vue | 2 +- .../notes/components/noteable_note.vue | 11 +- .../notes/components/notes_app.vue | 8 +- .../components/toggle_replies_widget.vue | 4 +- .../javascripts/pages/groups/new/index.js | 9 + .../components/notes/placeholder_note.vue | 24 +- .../components/notes/system_note.vue | 6 +- .../components/registry/history_item.vue | 6 +- .../new_namespace/new_namespace_page.vue | 11 + .../components/work_item_assignees.vue | 9 +- .../components/work_item_description.vue | 2 +- .../components/work_item_due_date.vue | 2 +- .../components/work_item_labels.vue | 9 +- .../work_item_links/work_item_links.vue | 2 +- .../work_item_links/work_item_links_form.vue | 2 +- .../components/work_item_type_icon.vue | 2 +- app/assets/stylesheets/framework/diffs.scss | 22 +- .../stylesheets/framework/timeline.scss | 26 +- .../page_bundles/merge_requests.scss | 4 +- app/assets/stylesheets/pages/issuable.scss | 7 +- app/assets/stylesheets/pages/notes.scss | 271 ++++++++++++++---- app/models/ci/build_metadata.rb | 1 + app/models/users/callout.rb | 3 +- app/services/web_hook_service.rb | 4 + .../shared/deploy_tokens/_form.html.haml | 2 +- app/views/shared/labels/_form.html.haml | 6 +- app/views/shared/notes/_note.html.haml | 15 +- .../webhooks_gitlab_instance_header.yml | 8 + .../sidekiq_memory_killer_read_only_mode.yml | 7 + .../settings/20211201012652_flavor.yml | 2 +- ...s_metadata_for_partitioning_primary_key.rb | 36 +++ ...20920141001_add_index_on_internal_notes.rb | 15 + db/schema_migrations/20220920081631 | 1 + db/schema_migrations/20220920141001 | 1 + db/structure.sql | 4 +- doc/api/graphql/reference/index.md | 1 + doc/api/search.md | 96 +++---- doc/user/project/integrations/webhooks.md | 17 ++ lib/gitlab/database/reflection.rb | 6 +- lib/gitlab/sidekiq_daemon/memory_killer.rb | 2 + lib/gitlab/web_hooks.rb | 1 + locale/gitlab.pot | 18 +- package.json | 4 +- scripts/build_qa_image | 32 +++ spec/features/groups/new_group_page_spec.rb | 32 +++ .../new_top_level_group_alert_spec.js | 75 +++++ .../__snapshots__/notes_app_spec.js.snap | 8 +- .../components/diff_discussion_header_spec.js | 2 +- .../notes/components/note_header_spec.js | 2 +- .../notes/components/noteable_note_spec.js | 2 +- .../placeholder_note_spec.js.snap | 23 +- .../components/notes/placeholder_note_spec.js | 14 - .../__snapshots__/history_item_spec.js.snap | 8 +- .../components/work_item_assignees_spec.js | 6 + .../components/work_item_labels_spec.js | 6 + .../components/work_item_type_icon_spec.js | 2 +- spec/lib/gitlab/database/reflection_spec.rb | 6 + .../sidekiq_daemon/memory_killer_spec.rb | 74 +++-- spec/services/web_hook_service_spec.rb | 21 +- yarn.lock | 16 +- 65 files changed, 798 insertions(+), 305 deletions(-) create mode 100644 app/assets/javascripts/groups/components/new_top_level_group_alert.vue create mode 100644 config/feature_flags/development/webhooks_gitlab_instance_header.yml create mode 100644 config/feature_flags/ops/sidekiq_memory_killer_read_only_mode.yml create mode 100644 db/post_migrate/20220920081631_prepare_ci_builds_metadata_for_partitioning_primary_key.rb create mode 100644 db/post_migrate/20220920141001_add_index_on_internal_notes.rb create mode 100644 db/schema_migrations/20220920081631 create mode 100644 db/schema_migrations/20220920141001 create mode 100755 scripts/build_qa_image create mode 100644 spec/features/groups/new_group_page_spec.rb create mode 100644 spec/frontend/groups/components/new_top_level_group_alert_spec.js diff --git a/.gitlab/ci/build-images.gitlab-ci.yml b/.gitlab/ci/build-images.gitlab-ci.yml index 1b041c9af38..3c7056a92c1 100644 --- a/.gitlab/ci/build-images.gitlab-ci.yml +++ b/.gitlab/ci/build-images.gitlab-ci.yml @@ -15,27 +15,7 @@ build-qa-image: stage: build-images needs: [] script: - # Tag with commit SHA by default - - export QA_IMAGE="${CI_REGISTRY}/${CI_PROJECT_PATH}/gitlab-ee-qa:${CI_COMMIT_SHA}" - # For branches, tag with slugified branch name. For tags, use the tag directly - - export QA_IMAGE_BRANCH="${CI_REGISTRY}/${CI_PROJECT_PATH}/gitlab-ee-qa:${CI_COMMIT_TAG:-$CI_COMMIT_REF_SLUG}" - # Auto-deploy tag format uses first 12 letters of commit SHA. Tag with that - # reference also - - export QA_IMAGE_FOR_AUTO_DEPLOY="${CI_REGISTRY}/${CI_PROJECT_PATH}/gitlab-ee-qa:${CI_COMMIT_SHA:0:11}" - - echo $QA_IMAGE - - echo $QA_IMAGE_BRANCH - - echo $QA_IMAGE_FOR_AUTO_DEPLOY - - | - /kaniko/executor \ - --context=${CI_PROJECT_DIR} \ - --dockerfile=${CI_PROJECT_DIR}/qa/Dockerfile \ - --destination=${QA_IMAGE} \ - --destination=${QA_IMAGE_BRANCH} \ - --destination=${QA_IMAGE_FOR_AUTO_DEPLOY} \ - --build-arg=CHROME_VERSION=${CHROME_VERSION} \ - --build-arg=DOCKER_VERSION=${DOCKER_VERSION} \ - --build-arg=QA_BUILD_TARGET=${QA_BUILD_TARGET:-qa} \ - --cache=true + - ./scripts/build_qa_image # This image is used by: # - The `CNG` pipelines (via the `review-build-cng` job): https://gitlab.com/gitlab-org/build/CNG/-/blob/cfc67136d711e1c8c409bf8e57427a644393da2f/.gitlab-ci.yml#L335 diff --git a/GITALY_SERVER_VERSION b/GITALY_SERVER_VERSION index 699e4a0c856..56481189ebf 100644 --- a/GITALY_SERVER_VERSION +++ b/GITALY_SERVER_VERSION @@ -1 +1 @@ -c13d9d902ef8175a0b1165ef0bc8643fb37b7897 +d7181e813e602f80bf53e47089da92b6342b355f diff --git a/app/assets/javascripts/diffs/components/diff_file_header.vue b/app/assets/javascripts/diffs/components/diff_file_header.vue index 705b43a222d..91c3df39e32 100644 --- a/app/assets/javascripts/diffs/components/diff_file_header.vue +++ b/app/assets/javascripts/diffs/components/diff_file_header.vue @@ -281,7 +281,7 @@ export default { 'gl-z-dropdown-menu!': idState.moreActionsShown, 'is-sidebar-moved': glFeatures.movedMrSidebar, }" - class="js-file-title file-title file-title-flex-parent" + class="js-file-title file-title file-title-flex-parent gl-border" data-qa-selector="file_title_container" :data-qa-file-name="filePath" @click.self="handleToggleFile" diff --git a/app/assets/javascripts/groups/components/new_top_level_group_alert.vue b/app/assets/javascripts/groups/components/new_top_level_group_alert.vue new file mode 100644 index 00000000000..c6af6cdb59f --- /dev/null +++ b/app/assets/javascripts/groups/components/new_top_level_group_alert.vue @@ -0,0 +1,40 @@ + + + diff --git a/app/assets/javascripts/notes/components/diff_discussion_header.vue b/app/assets/javascripts/notes/components/diff_discussion_header.vue index 1b1923a90f7..cf6474270a2 100644 --- a/app/assets/javascripts/notes/components/diff_discussion_header.vue +++ b/app/assets/javascripts/notes/components/diff_discussion_header.vue @@ -84,8 +84,8 @@ export default { return sprintf(text, { commitDisplay, linkStart, linkEnd }, false); }, - adaptiveAvatarSize() { - return { default: 24, md: 32 }; + toggleClass() { + return this.discussion.expanded ? 'expanded' : 'collapsed'; }, }, methods: { @@ -98,16 +98,13 @@ export default {