From 2dff04f24a8446216e12d43fab6841f28f3dd406 Mon Sep 17 00:00:00 2001
From: James Lopez <james@jameslopez.es>
Date: Fri, 13 May 2016 17:39:03 +0200
Subject: [PATCH] fixed TODOs left

---
 lib/gitlab/import_export.rb                    | 8 ++++++++
 lib/gitlab/import_export/project_tree_saver.rb | 7 +------
 lib/gitlab/import_export/repo_bundler.rb       | 7 +------
 3 files changed, 10 insertions(+), 12 deletions(-)

diff --git a/lib/gitlab/import_export.rb b/lib/gitlab/import_export.rb
index 6835411ba70..bf80ac7f093 100644
--- a/lib/gitlab/import_export.rb
+++ b/lib/gitlab/import_export.rb
@@ -9,5 +9,13 @@ module Gitlab
     def storage_path
       File.join(Settings.shared['path'], 'tmp/project_exports')
     end
+
+    def project_filename
+      "project.json"
+    end
+
+    def project_bundle_filename
+      "project.bundle"
+    end
   end
 end
diff --git a/lib/gitlab/import_export/project_tree_saver.rb b/lib/gitlab/import_export/project_tree_saver.rb
index 2287524c8a5..c894295b0f5 100644
--- a/lib/gitlab/import_export/project_tree_saver.rb
+++ b/lib/gitlab/import_export/project_tree_saver.rb
@@ -6,7 +6,7 @@ module Gitlab
       def initialize(project:, shared:)
         @project = project
         @shared = shared
-        @full_path = File.join(@shared.export_path, project_filename)
+        @full_path = File.join(@shared.export_path, ImportExport.project_filename)
       end
 
       def save
@@ -20,11 +20,6 @@ module Gitlab
 
       private
 
-      # TODO remove magic keyword and move it to a shared config
-      def project_filename
-        "project.json"
-      end
-
       def project_json_tree
         @project.to_json(Gitlab::ImportExport::ImportExportReader.new(shared: @shared).project_tree)
       end
diff --git a/lib/gitlab/import_export/repo_bundler.rb b/lib/gitlab/import_export/repo_bundler.rb
index bcf976fb624..aff6e92be70 100644
--- a/lib/gitlab/import_export/repo_bundler.rb
+++ b/lib/gitlab/import_export/repo_bundler.rb
@@ -12,7 +12,7 @@ module Gitlab
 
       def bundle
         return false if @project.empty_repo?
-        @full_path = File.join(@shared.export_path, project_filename)
+        @full_path = File.join(@shared.export_path, ImportExport.project_bundle_filename)
         bundle_to_disk
       end
 
@@ -26,11 +26,6 @@ module Gitlab
         false
       end
 
-      # TODO remove magic keyword and move it to a shared config
-      def project_filename
-        "project.bundle"
-      end
-
       def path_to_repo
         @project.repository.path_to_repo
       end