From ca1526e7ffa2b1eeccae187406987de0250c2012 Mon Sep 17 00:00:00 2001 From: Sytse Sijbrandij Date: Wed, 27 Nov 2013 09:00:14 +0100 Subject: [PATCH 1/2] Conventional naming for diff modes. --- CHANGELOG | 2 +- app/views/projects/commits/_diffs.html.haml | 4 ++-- app/views/projects/commits/_parallel_view.html.haml | 2 +- features/project/commits/commits.feature | 8 ++++---- features/steps/project/project_browse_commits.rb | 12 ++++++------ .../javascripts/ace-src-noconflict/mode-diff.js | 2 +- 6 files changed, 15 insertions(+), 15 deletions(-) diff --git a/CHANGELOG b/CHANGELOG index 2270341bcfb..d79b1f7a8fc 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -4,7 +4,7 @@ v 6.4.0 - Fixed another 500 error with submodules - UI: More compact issues page - Minimal password length increased to 8 symbols - - Parallel diff view (Steven Thonus) + - Side-by-side diff view (Steven Thonus) v 6.3.0 - API for adding gitlab-ci service diff --git a/app/views/projects/commits/_diffs.html.haml b/app/views/projects/commits/_diffs.html.haml index aec7f15cdb7..2a32f56e8f0 100644 --- a/app/views/projects/commits/_diffs.html.haml +++ b/app/views/projects/commits/_diffs.html.haml @@ -31,9 +31,9 @@ and %strong.cred #{@commit.stats.deletions} deletions - if params[:view] == 'parallel' - = link_to "Unified Diff", url_for(view: 'unified'), {id: "commit-diff-viewtype", class: 'btn btn-tiny pull-right'} + = link_to "Inline Diff", url_for(view: 'inline'), {id: "commit-diff-viewtype", class: 'btn btn-tiny pull-right'} - else - = link_to "Parallel Diff", url_for(view: 'parallel'), {id: "commit-diff-viewtype", class: 'btn btn-tiny pull-right'} + = link_to "Side-by-side Diff", url_for(view: 'parallel'), {id: "commit-diff-viewtype", class: 'btn btn-tiny pull-right'} .file-stats = render "projects/commits/diff_head", diffs: diffs diff --git a/app/views/projects/commits/_parallel_view.html.haml b/app/views/projects/commits/_parallel_view.html.haml index 6585bd140a1..3234e9da0ac 100644 --- a/app/views/projects/commits/_parallel_view.html.haml +++ b/app/views/projects/commits/_parallel_view.html.haml @@ -1,4 +1,4 @@ -/ Parallel diff view +/ Side-by-side diff view - old_file = get_old_file(project, @commit, diff) - deleted_lines = {} - added_lines = {} diff --git a/features/project/commits/commits.feature b/features/project/commits/commits.feature index 97113871a0a..cbe8b321507 100644 --- a/features/project/commits/commits.feature +++ b/features/project/commits/commits.feature @@ -14,12 +14,12 @@ Feature: Project Browse commits Scenario: I browse commit from list Given I click on commit link Then I see commit info - And I see parallel diff button + And I see side-by-side diff button - Scenario: I browse commit with parallel diff view + Scenario: I browse commit with side-by-side diff view Given I click on commit link - And I click parallel diff button - Then I see unified diff button + And I click side-by-side diff button + Then I see inline diff button Scenario: I compare refs Given I visit compare refs page diff --git a/features/steps/project/project_browse_commits.rb b/features/steps/project/project_browse_commits.rb index 17c51dc9a96..0376c892696 100644 --- a/features/steps/project/project_browse_commits.rb +++ b/features/steps/project/project_browse_commits.rb @@ -89,16 +89,16 @@ class ProjectBrowseCommits < Spinach::FeatureSteps links[1]['href'].should =~ %r{blob/cc1ba255d6c5ffdce87a357ba7ccc397a4f4026b} end - Given 'I click parallel diff button' do - click_link "Parallel Diff" + Given 'I click side-by-side diff button' do + click_link "side-by-side Diff" end - Then 'I see parallel diff button' do - page.should have_content "Parallel Diff" + Then 'I see side-by-side diff button' do + page.should have_content "Side-by-side Diff" end - Then 'I see unified diff button' do - page.should have_content "Unified Diff" + Then 'I see inline diff button' do + page.should have_content "Inline Diff" end end diff --git a/vendor/assets/javascripts/ace-src-noconflict/mode-diff.js b/vendor/assets/javascripts/ace-src-noconflict/mode-diff.js index 75e26cc7056..8d1e7cee096 100644 --- a/vendor/assets/javascripts/ace-src-noconflict/mode-diff.js +++ b/vendor/assets/javascripts/ace-src-noconflict/mode-diff.js @@ -66,7 +66,7 @@ var DiffHighlightRules = function() { "regex": "^(?:\\*{15}|={67}|-{3}|\\+{3})$", "token": "punctuation.definition.separator.diff", "name": "keyword" - }, { //diff.range.unified + }, { //diff.range.inline "regex": "^(@@)(\\s*.+?\\s*)(@@)(.*)$", "token": [ "constant", From 68726c5bb4b2fed89e9bce9de76e383eccb0a365 Mon Sep 17 00:00:00 2001 From: Sytse Sijbrandij Date: Wed, 27 Nov 2013 17:57:55 +0100 Subject: [PATCH 2/2] Button name has an upcase in it. --- features/steps/project/project_browse_commits.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/features/steps/project/project_browse_commits.rb b/features/steps/project/project_browse_commits.rb index 0376c892696..d667b58240f 100644 --- a/features/steps/project/project_browse_commits.rb +++ b/features/steps/project/project_browse_commits.rb @@ -90,7 +90,7 @@ class ProjectBrowseCommits < Spinach::FeatureSteps end Given 'I click side-by-side diff button' do - click_link "side-by-side Diff" + click_link "Side-by-side Diff" end Then 'I see side-by-side diff button' do