Improce specs of authentication activity class methods
This commit is contained in:
parent
00e4d918a3
commit
2ead2b9748
|
@ -1,14 +1,30 @@
|
||||||
require 'spec_helper'
|
require 'fast_spec_helper'
|
||||||
|
|
||||||
describe Gitlab::Auth::Activity do
|
describe Gitlab::Auth::Activity do
|
||||||
describe '#each_counter' do
|
describe '.each_counter' do
|
||||||
it 'has all static counters defined' do
|
it 'has all static counters defined' do
|
||||||
described_class.each_counter do |counter|
|
described_class.each_counter do |counter|
|
||||||
expect(described_class).to respond_to(counter)
|
expect(described_class).to respond_to(counter)
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
||||||
# todo incrementer pairs
|
it 'has all static incrementers defined' do
|
||||||
# todo all metrics starting with `user`_
|
described_class.each_counter do |counter|
|
||||||
|
expect(described_class).to respond_to("#{counter}_increment!")
|
||||||
|
end
|
||||||
|
end
|
||||||
|
|
||||||
|
it 'has all counters starting with `user_`' do
|
||||||
|
described_class.each_counter do |counter|
|
||||||
|
expect(counter).to start_with('user_')
|
||||||
|
end
|
||||||
|
end
|
||||||
|
|
||||||
|
it 'yields counter method, name and description' do
|
||||||
|
described_class.each_counter do |method, name, description|
|
||||||
|
expect(method).to eq "#{name}_counter"
|
||||||
|
expect(description).to start_with('Counter of')
|
||||||
|
end
|
||||||
|
end
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
Loading…
Reference in New Issue