diff --git a/.eslintrc.yml b/.eslintrc.yml index 59eec634e8b..524ce64118f 100644 --- a/.eslintrc.yml +++ b/.eslintrc.yml @@ -1,5 +1,6 @@ extends: - '@gitlab' + - plugin:promise/recommended globals: __webpack_public_path__: true gl: false @@ -42,6 +43,11 @@ rules: no-jquery/no-load: error no-jquery/no-load-shorthand: error no-jquery/no-serialize: error + promise/always-return: off + promise/no-callback-in-promise: off + promise/no-nesting: off + promise/param-names: off + promise/valid-params: off overrides: files: - '**/spec/**/*' diff --git a/.gitlab/ci/global.gitlab-ci.yml b/.gitlab/ci/global.gitlab-ci.yml index 70f3620aa79..49dd778f4fb 100644 --- a/.gitlab/ci/global.gitlab-ci.yml +++ b/.gitlab/ci/global.gitlab-ci.yml @@ -100,6 +100,7 @@ refs: - master - /^\d+-\d+-auto-deploy-\d+$/ + - /^[\d-]+-stable(-ee)?$/ .only-review-schedules: only: diff --git a/.gitlab/ci/review.gitlab-ci.yml b/.gitlab/ci/review.gitlab-ci.yml index 9251644911f..01e4b1afdb0 100644 --- a/.gitlab/ci/review.gitlab-ci.yml +++ b/.gitlab/ci/review.gitlab-ci.yml @@ -1,8 +1,15 @@ +.except-deploys: + except: + refs: + - /^[\d-]+-stable(-ee)?$/ + - /^\d+-\d+-auto-deploy-\d+$/ + .review-docker: extends: - .default-tags - .default-retry - .default-only + - .except-deploys image: registry.gitlab.com/gitlab-org/gitlab-build-images:gitlab-qa-alpine services: - docker:19.03.0-dind @@ -36,6 +43,7 @@ schedule:review-cleanup: - .default-only - .only-code-qa-changes - .only-review-schedules + - .except-deploys stage: prepare image: registry.gitlab.com/gitlab-org/gitlab-build-images:gitlab-charts-build-base allow_failure: true @@ -52,6 +60,7 @@ schedule:review-cleanup: extends: - .default-only - .only-code-qa-changes + - .except-deploys image: ruby:2.6-alpine stage: review-prepare before_script: @@ -80,6 +89,7 @@ schedule:review-build-cng: - .default-retry - .default-only - .only-code-qa-changes + - .except-deploys stage: review image: registry.gitlab.com/gitlab-org/gitlab-build-images:gitlab-charts-build-base dependencies: [] @@ -257,6 +267,7 @@ parallel-spec-reports: - .default-only - .only-code-qa-changes - .only-review + - .except-deploys image: ruby:2.6-alpine stage: post-test dependencies: ["review-qa-all"] diff --git a/app/assets/javascripts/commons/vue.js b/app/assets/javascripts/commons/vue.js index 8b62d78c043..5b5a1507d38 100644 --- a/app/assets/javascripts/commons/vue.js +++ b/app/assets/javascripts/commons/vue.js @@ -1,5 +1,8 @@ import Vue from 'vue'; +import GlFeatureFlagsPlugin from '~/vue_shared/gl_feature_flags_plugin'; if (process.env.NODE_ENV !== 'production') { Vue.config.productionTip = false; } + +Vue.use(GlFeatureFlagsPlugin); diff --git a/app/assets/javascripts/monitoring/components/dashboard.vue b/app/assets/javascripts/monitoring/components/dashboard.vue index 12a4c83e053..b5ed54a6e25 100644 --- a/app/assets/javascripts/monitoring/components/dashboard.vue +++ b/app/assets/javascripts/monitoring/components/dashboard.vue @@ -175,7 +175,6 @@ export default { 'metricsWithData', 'useDashboardEndpoint', 'allDashboards', - 'multipleDashboardsEnabled', 'additionalPanelTypesEnabled', ]), firstDashboard() { @@ -318,7 +317,6 @@ export default {